Only show label if the shareWith value is relevant #12334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For local users / groups the display name is enough to show, we just need details for email/remote shares Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
MorrisJobke,
blizzz,
danxuliu,
jancborchardt and
skjnldsv
blizzz
approved these changes
Nov 7, 2018
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
code looks good and works as expected, thx!
MorrisJobke
approved these changes
Nov 7, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested, works and looks nice 👍
blizzz
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For local users / groups the display name is enough to show, we just need details for email/remote shares
Before:
After:
Fixes #12164