Skip to content

Fix inline input confirm margin #12388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Nov 11, 2018
Merged

Fix inline input confirm margin #12388

MorrisJobke merged 1 commit into from
Nov 11, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 10, 2018 •
edited
Loading

@nextcloud/designers

Before After
capture d ecran_2018-11-09_13-39-45 capture d ecran_2018-11-09_13-39-39

@skjnldsv
Fix inline input confirm margin
dbcea33 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Nov 10, 2018
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 10, 2018
@skjnldsv skjnldsv self-assigned this Nov 10, 2018
@rullzer
Copy link
Member

rullzer commented Nov 11, 2018

How on earth do you spot this kind of stuff? Do you work on zoom 1600% or what?

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 11, 2018

I have issues! 🙈
When I spot things like that, I get mad!!

MorrisJobke
MorrisJobke approved these changes Nov 11, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full ack 👍 😆

@MorrisJobke MorrisJobke merged commit 6324961 into master Nov 11, 2018
@MorrisJobke MorrisJobke deleted the inline-input-confirm-margin-fix branch November 11, 2018 22:34
@MorrisJobke MorrisJobke mentioned this pull request Nov 12, 2018
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @rullzer @MorrisJobke