-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Customize presentation of accept/decline buttons in iMip mail #12392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rullzer
merged 7 commits into
nextcloud:master
from
brad2014:feature/properly-present-buttons-from-imip-mails
Aug 15, 2019
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
31a25dc
Customize presentation of accept/decline buttons in iMip mail
15400dd
corrected sample config
6421e30
Respect RSVP parameter for attendees when adding accept/decline buttons.
79d20e4
Revert 3ff3ed0c56 case-insensitive compares.
1dbda26
IMipPlugin: Added unit test for dav.invitation_link_recipients support
1a29239
IMipPlugin: DRY up - move common test set-up into setUp function
8d8bcea
Move dav.invitation_link_recipients from getSystemValue to getAppValue
brad2014 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Customize presentation of accept/decline buttons in iMip mail
Fix Issue #11230 Only present accept/decline button links in iMip mail for REQUEST, not CANCEL or others. Fix Issue #12156 Implement config setting "dav.invitation_link_recipients", to control which invitation recipients see accept/decline button links. The default, for public internet facing servers, is to always include them. For a server on a private intranet, this setting can be set to the email addresses or email domains of users whose browsers can access the nextcloud server referenced by those accept/decline button links. It can also be set to "false" to exclude the links from all requests. Signed-off-by: Brad Rubenstein <[email protected]>
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1696,6 +1696,33 @@ | |
| '/^Microsoft-WebDAV-MiniRedir/', // Windows webdav drive | ||
| ), | ||
|
|
||
| /** | ||
| * The caldav server sends invitation emails to invitees, attaching the ICS | ||
| * file for the invitation. It also may include, in the body of the e-mail, | ||
| * invitation accept/reject web links referencing URL's that point to the nextcloud server. | ||
| * | ||
| * Although any recipient can read and reply to the ICS file via the iMip protocol, | ||
| * we must only present the web links to recipients who can access the nextcloud | ||
| * web server via their internet/intranet. | ||
| * | ||
| * When your nextcloud server is restricted behind a firewall, accessible | ||
| * only via an internal network or via vpn, you can set "dav.invitation_link_recipients" | ||
| * to the email address or email domain, or array of addresses or domains, | ||
| * of recipients who can access the server. Only those recipients will get web links. External | ||
| * users can accept/reject invitations by emailing back ICS files containing appropriate | ||
| * messages, using the iMip protocol. Many mail clients support this functionality. | ||
| * | ||
| * To suppress iMip web links entirely, set dav.invitation_link_recipients to false. | ||
| * To deliver iMip web links always, set dav.invitation_link_recipients to true. | ||
| * | ||
| * Examples: | ||
| * 'dav.invitation_link_recipients' => 'internal.example.com', | ||
| * 'dav.invitation_link_recipients' => array( 'internal.example.com', '[email protected]' ), | ||
| * 'dav.invitation_link_recipients' => false, | ||
| * | ||
| */ | ||
| 'dav.invitation_link_recipients' => '*', // always include accept/reject server links in iMip emails | ||
|
||
|
|
||
| /** | ||
| * By default there is on public pages a link shown that allows users to | ||
| * learn about the "simple sign up" - see https://nextcloud.com/signup/ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: One more place where mailto scheme comparison should be case insensitive (if the event contained MAILTO, then it would not have properly been detected). This is related to the fix nextcloud/calendar@82fc0a9 by @georgehrke.