Use nextcloud-password-confirmation #12409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added a commit
to skjnldsv/nextcloud-password-confirmation
that referenced
this pull request
Nov 12, 2018
To work with nextcloud/server#12409
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
admin-vue-approval-fix
branch
from
b37995f to
1cb5f31
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
added
3. to review
ChristophWurst
approved these changes
Nov 12, 2018
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
The nicest!
Haven't tested, but code looks good 👍
blizzz
added
4. to release
Member
|
@MorrisJobke one does not simply merge fixup commits |
Member
|
@rullzer guess we need that CI check you once mentioned ;) |
Member
|
See ;) told you! |
Member
Author
|
Backport in #12416 |
Member
Then don't set "4 - To release" if the history is not ready ;) |
Member
🙈 |
Member
|
Didn't review commit messages, only code 👅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11224
Needs nextcloud-libraries/nextcloud-password-confirmation#1