Prefix icon variables with app name to avoid conflicts #12421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
MorrisJobke,
danxuliu,
rullzer,
skjnldsv and
weeman1337
skjnldsv
approved these changes
Nov 12, 2018
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Awesome stuff on your last pr!! You 🎸 !!
MorrisJobke
approved these changes
Nov 12, 2018
Member
|
Jsunit tests failed 🙈 |
MorrisJobke
added
2. developing
Member
|
@juliushaertl Would be nice to get them fixed for tomorrow 😃 |
juliusknorr
force-pushed
the
bugfix/noid/icons-cacher-app-prefix
branch
from
a95fc1a to
56ad676
Compare
MorrisJobke
added
4. to release
Member
|
JSUnit still fails 🙈 |
MorrisJobke
added
2. developing
juliusknorr
force-pushed
the
bugfix/noid/icons-cacher-app-prefix
branch
from
56ad676 to
da6cf15
Compare
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/icons-cacher-app-prefix
branch
from
da6cf15 to
521b2dd
Compare
MorrisJobke
added
4. to release
Member
Author
MorrisJobke
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise apps with the same icon name will overwrite each other.
Example:
deck uses:
@include icon-color('app', 'deck', $color-black);calendar uses:
@include icon-color('app', 'calendar', $color-black);Before:
Both icon variables have the same name
--icon-app-000Before:
deck uses
--icon-deck-app-000calendar uses
--icon-calendar-app-000