Skip to content

Fix SetVcardDatabaseUID when using postgresql #12439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Nov 13, 2018
Merged

Fix SetVcardDatabaseUID when using postgresql #12439

MorrisJobke merged 1 commit into from
Nov 13, 2018

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 13, 2018

On my postgresql instance the carddata column is of the bytea type, and when selecting it PDO apparently returns it as a stream instead of an array.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 13, 2018
@icewind1991 icewind1991 added this to the Nextcloud 15 milestone Nov 13, 2018
@skjnldsv
Copy link
Member

skjnldsv commented Nov 13, 2018

It's strange that the tests was passing!
Thanks a lot @icewind1991 for finding this out! 🤗

skjnldsv
skjnldsv approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

MorrisJobke
MorrisJobke approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 13, 2018
@MorrisJobke MorrisJobke merged commit e36924e into master Nov 13, 2018
@MorrisJobke MorrisJobke deleted the vcard_uid_repair_postgres branch November 13, 2018 15:22
@MorrisJobke MorrisJobke mentioned this pull request Nov 14, 2018
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @skjnldsv @MorrisJobke