Skip to content

Don't register twofactor_backup settings as "regular" settings #12455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 2 commits into from
Nov 14, 2018
Merged

Don't register twofactor_backup settings as "regular" settings #12455

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2482e8e
Log invalid settings class
icewind1991 Nov 14, 2018
7ac15d4
twofactor auth settings are not regular settings
icewind1991 Nov 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Log invalid settings class 
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991
icewind1991 committed Nov 14, 2018
commit 2482e8ee3429ebca2baf49c69929983a2c578736
2 changes: 1 addition & 1 deletion lib/private/Settings/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ protected function getSettings(string $type, string $section): array {
}

if (!$setting instanceof ISettings) {
$this->log->logException(new \InvalidArgumentException('Invalid settings setting registered'), ['level' => ILogger::INFO]);
$this->log->logException(new \InvalidArgumentException('Invalid settings setting registered (' . $class . ')'), ['level' => ILogger::INFO]);
continue;
}

Expand Down