Skip to content

return the correct value when trying to get a non existing item from cache by id #12494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Nov 20, 2018
Merged

return the correct value when trying to get a non existing item from cache by id #12494

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d5cfef
return the correct value when trying to get a non existing item from …
icewind1991 Nov 16, 2018
aa6f794
add test for non existing file by id
icewind1991 Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add test for non existing file by id 
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991
icewind1991 committed Nov 19, 2018
commit aa6f7947bacbf8eeb7eae4f5db7c0a52d7b4bbfa
1 change: 1 addition & 0 deletions tests/lib/Files/Cache/CacheTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,7 @@ function testGetIncomplete() {

function testNonExisting() {
$this->assertFalse($this->cache->get('foo.txt'));
$this->assertFalse($this->cache->get(-1));
$this->assertEquals(array(), $this->cache->getFolderContents('foo'));
}

Expand Down