Respect the disabled setting for lost_password_link #12552
Conversation
Fixes #11146 As documented when it is set to disabled the user can't request a lost password. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
requested review from
ChristophWurst,
MorrisJobke,
danxuliu,
juliusknorr and
nickvergessen
|
/backport to stable14 |
MorrisJobke
added
4. to release
|
backport to stable14 in #12555 |
HigH-HawK
left a comment
HigH-HawK
left a comment
There was a problem hiding this comment.
It works as far as it removes the link from the login page but it causes the LDAP function to misbehave.
As mentioned in the forums: https://help.nextcloud.com/t/ldap-error-in-14-0-4-after-changing-lost-password-link-behaviour-bind-failed-50-insufficient-access/42060
When this change is being done and the user enters a wrong password, the user is getting an internal server error and the NC log states that it could not connect to the LDAP server, despite the LDAP server being available as other users could login fine at the same time.
Further testing brought to daylight, that this behaviour only happens if the entered username is part of the LDAP server. If you enter a fictional username and password, it brings up the correct message "wrong password"
Fixes #11146
As documented when it is set to disabled the user can't request a lost
password.
Signed-off-by: Roeland Jago Douma [email protected]