Do not switch to root folder if filelist is already shown #12554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
MorrisJobke,
icewind1991,
rullzer and
skjnldsv
Member
Author
|
/backport to stable14 |
skjnldsv
approved these changes
Nov 20, 2018
Member
|
JSUnit fails: |
MorrisJobke
added
4. to release
Member
|
@juliushaertl Mind to look into this to get the fix shipped in the RC 1 |
MorrisJobke
added
2. developing
Member
Author
|
@MorrisJobke I'm on it, the test actually catched a bug of this solution, so I'll need to do some adjustments to the fix. |
Navigating to the root folder is already handled by OCA.Files.Navigation.setActiveItem in case the view doesn't change. Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/12493/root-folder-switch
branch
from
2b1d43c to
a90b4bc
Compare
Member
Author
|
@MorrisJobke I think I found a way to stop triggering the reload without interfering with existing behaviour. Please give this another test @ChristophWurst @skjnldsv since the logic changed a bit to work around the crazy event passing happening in the files app. |
juliusknorr
added
3. to review
MorrisJobke
added
4. to release
Member
|
/backport to stable14 |
|
backport to stable14 in #12593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigating to the root folder is already handled by OCA.Files.Navigation.setActiveItem in case the view doesn't change.
Fixes #12493 since there was a race condition between the root folder loading for falling back when clicking the All files sidebar entry and the actual view that should be loaded.