Skip to content

extend anonymous options to work on every dav url #12556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
icewind1991 merged 1 commit into from
Nov 23, 2018
Merged

extend anonymous options to work on every dav url #12556

icewind1991 merged 1 commit into from
Nov 23, 2018

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 20, 2018

Signed-off-by: Robin Appelman [email protected]

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 20, 2018
@icewind1991 icewind1991 added this to the Nextcloud 15 milestone Nov 20, 2018
MorrisJobke
MorrisJobke approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 20, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 22, 2018

Unit tests fail:

There was 1 failure:
1) OCA\DAV\tests\unit\DAV\AnonymousOptionsTest::testAnonymousOptionsNonRoot
Failed asserting that 200 matches expected 401.

/drone/src/github.com/nextcloud/server/apps/dav/tests/unit/DAV/AnonymousOptionsTest.php:57

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 22, 2018
@icewind1991 icewind1991 force-pushed the anonymous-options-all branch from 8432e89 to ffd7778 Compare November 23, 2018 14:37
@icewind1991 icewind1991 added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 23, 2018
@icewind1991 icewind1991 merged commit eadfa90 into master Nov 23, 2018
@icewind1991 icewind1991 deleted the anonymous-options-all branch November 23, 2018 17:14
@icewind1991
Copy link
Member Author

icewind1991 commented Nov 23, 2018

!backport to stable15

@rullzer
Copy link
Member

rullzer commented Nov 23, 2018

/backport to stable15

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 23, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Nov 23, 2018

backport to stable15 in #12638

@icewind1991
Copy link
Member Author

icewind1991 commented Nov 23, 2018

/backport to stable14

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 23, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Nov 23, 2018

backport to stable14 in #12639

@georgehrke georgehrke mentioned this pull request Dec 2, 2018
Closed
@juliusknorr juliusknorr mentioned this pull request Aug 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @MorrisJobke @rullzer