Skip to content

Fix rendering of the sidebar in Files app #12577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 5 commits into from
Nov 22, 2018
Merged

Fix rendering of the sidebar in Files app #12577

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
139e221
Add acceptance tests for switching to the comments of another file
danxuliu Nov 22, 2018
94645ed
Add acceptance tests for marking a file as favorite in the details view
danxuliu Nov 22, 2018
57ffa9e
Add acceptance tests for opening and closing again the details view
danxuliu Nov 22, 2018
1d17086
Add acceptance tests for showing again the input field for tags
danxuliu Nov 22, 2018
e39db80
Fix rendering of the sidebar in Files app
danxuliu Nov 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add acceptance tests for opening and closing again the details view 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Nov 22, 2018
commit 57ffa9ea73f6be9b2b72dcac6bfa6d4c208e80e4
37 changes: 37 additions & 0 deletions tests/acceptance/features/app-files.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,42 @@
Feature: app-files

Scenario: open and close the details view
Given I am logged in
When I open the details view for "welcome.txt"
And I see that the details view is open
And I close the details view
Then I see that the details view is closed

Scenario: open and close the details view twice
Given I am logged in
And I open the details view for "welcome.txt"
And I see that the details view is open
And I close the details view
And I see that the details view is closed
When I open the details view for "welcome.txt"
And I see that the details view is open
And I close the details view
Then I see that the details view is closed

Scenario: open and close the details view again after coming back from a different section
Given I am logged in
And I open the details view for "welcome.txt"
And I see that the details view is open
And I close the details view
And I see that the details view is closed
And I open the "Recent" section
And I see that the current section is "Recent"
And I open the details view for "welcome.txt"
And I see that the details view is open
And I close the details view
And I see that the details view is closed
When I open the "All files" section
And I see that the current section is "All files"
And I open the details view for "welcome.txt"
And I see that the details view is open
And I close the details view
Then I see that the details view is closed

Scenario: viewing a favorite file in its folder shows the correct sidebar view
Given I am logged in
And I create a new folder named "other"
Expand Down