Skip to content

Validate all rich objects #12624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Dec 4, 2018
Merged

Validate all rich objects #12624

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
695e602
Validate all rich objects not only the used ones
nickvergessen Nov 23, 2018
99bcc13
Fix wrong used type
nickvergessen Nov 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Validate all rich objects not only the used ones 
Signed-off-by: Joas Schilling <coding@schilljs.com>
  • Loading branch information
@nickvergessen
nickvergessen committed Nov 23, 2018
commit 695e60228d0a2441dcbb3b8512d9b9be4fbfd2d8
10 changes: 8 additions & 2 deletions lib/private/RichObjectStrings/Validator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,17 @@ public function validate($subject, array $parameters) {
foreach ($matches[1] as $parameter) {
if (!isset($parameters[$parameter])) {
throw new InvalidObjectExeption('Parameter is undefined');
} else {
$this->validateParameter($parameters[$parameter]);
}
}
}

foreach ($parameters as $parameter) {
if (!\is_array($parameter)) {
throw new InvalidObjectExeption('Parameter is malformed');
}

$this->validateParameter($parameter);
}
}

/**
Expand Down