handle mail send error gracefully #12636

schiessle · 2018-11-23T15:57:02Z

log the error in case a notification mail of a new share couldn't
be send to the recipient and finish the share operation successfully

I would suggest to backport it at least to stable15 and stable14

fix #12597

rullzer · 2018-11-26T10:10:33Z

/backport to stable15

rullzer · 2018-11-26T10:10:39Z

/backport to stable14

lib/private/Share20/Manager.php

ChristophWurst

Typo 😉

Is the returned bool used?

lib/private/Share20/Manager.php

ChristophWurst

Result is never checked.

Ref

server/lib/private/Share20/Manager.php

Lines 687 to 694 in 0f8de6e

    
           $this->sendMailNotification( 
        
           	$l, 
        
           	$share->getNode()->getName(), 
        
           	$this->urlGenerator->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $share->getNode()->getId()]), 
        
           	$share->getSharedBy(), 
        
           	$emailAddress, 
        
           	$share->getExpirationDate() 
        
           );

lib/private/Share20/Manager.php

schiessle · 2018-12-04T18:35:04Z

typo fixed

lib/private/Share20/Manager.php

log the error in case a notification mail of a new share couldn't be send to the recipient and finish the share operation successfully Signed-off-by: Bjoern Schiessle <[email protected]>

Signed-off-by: Bjoern Schiessle <[email protected]>

ChristophWurst

I'm fine with @schiessle's changes as this method is solely used in this class 👍

lib/private/Share20/Manager.php

Signed-off-by: Christoph Wurst <[email protected]>

MorrisJobke

Code looks good 👍

backportbot-nextcloud · 2019-01-30T19:08:30Z

backport to stable15 in #13930

backportbot-nextcloud · 2019-01-30T19:11:26Z

backport to stable14 in #13931

schiessle requested review from MorrisJobke, blizzz and rullzer November 23, 2018 15:57

schiessle added bug 3. to review Waiting for reviews feature: sharing backport-request labels Nov 23, 2018

schiessle added this to the Nextcloud 15 milestone Nov 23, 2018

rullzer approved these changes Nov 26, 2018

View reviewed changes

MorrisJobke reviewed Nov 26, 2018

View reviewed changes

lib/private/Share20/Manager.php Outdated Show resolved Hide resolved

MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 28, 2018

ChristophWurst added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 29, 2018

ChristophWurst requested changes Nov 29, 2018

View reviewed changes

lib/private/Share20/Manager.php Outdated Show resolved Hide resolved

ChristophWurst requested changes Nov 29, 2018

View reviewed changes

This comment has been minimized.

Sign in to view

MorrisJobke modified the milestones: Nextcloud 15, Nextcloud 15.0.1 Nov 30, 2018

blizzz reviewed Nov 30, 2018

View reviewed changes

lib/private/Share20/Manager.php Outdated Show resolved Hide resolved

MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 30, 2018

skjnldsv mentioned this pull request Dec 4, 2018

Error while creating a new user with an email address #12622

Closed

schiessle added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 4, 2018

MorrisJobke reviewed Dec 5, 2018

View reviewed changes

lib/private/Share20/Manager.php Outdated Show resolved Hide resolved

MorrisJobke mentioned this pull request Jan 4, 2019

15.0.1 RC 1 #13346

Merged

3 tasks

MorrisJobke modified the milestones: Nextcloud 15.0.1, Nextcloud 15.0.2, Nextcloud 15.0.3 Jan 4, 2019

MorrisJobke mentioned this pull request Jan 30, 2019

15.0.3 RC 1 #13912

Merged

schiessle added 3 commits January 30, 2019 15:25

handle mail send error gracefully

a943580

log the error in case a notification mail of a new share couldn't be send to the recipient and finish the share operation successfully Signed-off-by: Bjoern Schiessle <[email protected]>

log full exception

ab01402

Signed-off-by: Bjoern Schiessle <[email protected]>

fix typo

8ed004d

Signed-off-by: Bjoern Schiessle <[email protected]>

MorrisJobke modified the milestones: Nextcloud 15.0.3, Nextcloud 15.0.4 Jan 30, 2019

ChristophWurst force-pushed the fix-12597 branch from 50860b8 to 8cc2ee6 Compare January 30, 2019 14:33

ChristophWurst approved these changes Jan 30, 2019

View reviewed changes

ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 30, 2019

kesselb reviewed Jan 30, 2019

View reviewed changes

lib/private/Share20/Manager.php Outdated Show resolved Hide resolved

Fix typos and unused return values

7e3e3be

Signed-off-by: Christoph Wurst <[email protected]>

ChristophWurst force-pushed the fix-12597 branch from 8cc2ee6 to 7e3e3be Compare January 30, 2019 15:08

MorrisJobke approved these changes Jan 30, 2019

View reviewed changes

MorrisJobke modified the milestones: Nextcloud 15.0.4, Nextcloud 16 Jan 30, 2019

MorrisJobke mentioned this pull request Jan 30, 2019

14.0.7 RC 1 #13913

Merged

rullzer merged commit 85d6d7b into master Jan 30, 2019

rullzer deleted the fix-12597 branch January 30, 2019 19:05

backportbot-nextcloud bot mentioned this pull request Jan 30, 2019

[stable15] handle mail send error gracefully #13930

Merged

backportbot-nextcloud bot mentioned this pull request Jan 30, 2019

[stable14] handle mail send error gracefully #13931

Merged

backportbot-nextcloud bot removed the backport-request label Jan 30, 2019

	$this->sendMailNotification(
	$l,
	$share->getNode()->getName(),
	$this->urlGenerator->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $share->getNode()->getId()]),
	$share->getSharedBy(),
	$emailAddress,
	$share->getExpirationDate()
	);

Uh oh!

handle mail send error gracefully #12636

handle mail send error gracefully #12636

Uh oh!

Conversation

schiessle commented Nov 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rullzer commented Nov 26, 2018

Uh oh!

rullzer commented Nov 26, 2018

Uh oh!

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

schiessle commented Dec 4, 2018

Uh oh!

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

backportbot-nextcloud bot commented Jan 30, 2019

Uh oh!

backportbot-nextcloud bot commented Jan 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

schiessle commented Nov 23, 2018 •

edited

Loading