Skip to content

Polishing fixes #12732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 3 commits into from
Nov 29, 2018
Merged

Polishing fixes #12732

MorrisJobke merged 3 commits into from
Nov 29, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 29, 2018 •
edited
Loading

  • Removed the sidebar animations causing some hidden entries to be still focusable on keyboard navigation
  • Fixed the grid view and default for the filepicker
  • Fixed the filepicker grid view design on the files list
  • Fixed the edit entries buttons in the appnavigation (big round borders)

@skjnldsv
Fix app navigation edit entry
80b3452 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Fix default filepicker style and gridview
d526ab5 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Remove animation on the sidebar for accessibility purpose
ac7c778 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 29, 2018
@skjnldsv skjnldsv self-assigned this Nov 29, 2018
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 29, 2018

/backport to stable15

@jancborchardt jancborchardt mentioned this pull request Nov 29, 2018
Closed
47 tasks
MorrisJobke
MorrisJobke approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

ChristophWurst
ChristophWurst approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested and don't know if works but code looks good 👍

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 29, 2018 

* Removed the sidebar animations causing some hidden entries to be still focusable on keyboard navigation

Tested this with Mail and works 👍

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 29, 2018
@MorrisJobke MorrisJobke merged commit 6aefd83 into master Nov 29, 2018
@MorrisJobke MorrisJobke deleted the polishing-fixes branch November 29, 2018 17:21
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 29, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Nov 29, 2018

backport to stable15 in #12740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: accessibility

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @ChristophWurst @MorrisJobke