Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove animation on the sidebar for accessibility purpose
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
  • Loading branch information
skjnldsv authored and Backportbot committed Nov 29, 2018
commit 869867890a1e8c516b2aff7b90512badfe1df9c1
28 changes: 6 additions & 22 deletions core/css/apps.scss
Original file line number Diff line number Diff line change
Expand Up @@ -171,16 +171,12 @@ kbd {
top: 22px;
}

/* hide and animate deletion/collapse of subitems */
/* hide deletion/collapse of subitems */
&.deleted,
&.collapsible:not(.open) {
> ul {
opacity: 0;
max-height: 0;
overflow-y: hidden;
/* bezier override the hide/slow effect due to the 2000 max-height */
transition: max-height 1000ms cubic-bezier(0, 1, 0, 1),
opacity 250ms ease-in-out;
// NO ANIMATE because if not really hidden, we can still tab through it
display: none;
}
}

Expand All @@ -205,10 +201,6 @@ kbd {
> ul {
flex: 0 1 auto;
width: 100%;
transition: max-height 2000ms ease-in-out,
opacity 250ms ease-in-out;
max-height: 9999px;
opacity: 1;
position: relative;
> li {
display: inline-flex;
Expand Down Expand Up @@ -387,23 +379,15 @@ kbd {
-webkit-transform: rotate(-90deg);
-ms-transform: rotate(-90deg);
transform: rotate(-90deg);
z-index: 50;
z-index: 105; // above a, under button
background-color: var(--color-main-background);
transition: opacity $animation-quick ease-in-out;
}

/* force padding on link no matter if 'a' has an icon class */
> a:first-child {
padding-left: 44px;
}
&:before,
> a {
transition: background-position 100ms ease-in-out,
transform 250ms ease-in-out,
opacity 100ms ease-in-out;
}
&:hover > a,
&:focus > a {
background-position-x: -50px;
}
&:hover,
&:focus {
&:before {
Expand Down