make a button out of 'What's new' so it's obvious it can be clicked on

[violoncelloCH]

for #12694

Signed-off-by: Jonas Sulzer [email protected]

[ChristophWurst]

Conflicting files

apps/updatenotification/js/updatenotification.js
apps/updatenotification/js/updatenotification.js.map

FYI 😉

[ChristophWurst]

Makes sense!

[violoncelloCH]

Conflicting files

apps/updatenotification/js/updatenotification.js
apps/updatenotification/js/updatenotification.js.map

FYI wink

@ChristophWurst Does this mean I have to rebase my PR?

[skjnldsv]

@violoncelloCH rebase, ignore the changes on those two files, compile again, git add changes and finish rebase :)

[jancborchardt]

Btw @violoncelloCH for design fixes it’s always good to add a quick screenshot so others can verify it looks like you want it to. 🙂

[violoncelloCH]

@skjnldsv thank you -- rebase done
@jancborchardt yes, I will do this next time. Problem is for a correct screenshot I would have needed to fake an update response from the server again, what would have taken me some time... therefore here a screenshot of the button but with an empty popover:

[kesselb]

#12677 (comment) when you need a fake updater response ;-)

[jancborchardt]

@violoncelloCH no problem! :) It looks good, but could you also add class="primary" to the "Open updater" button? Because now the 2 same-looking buttons next to each other look a bit strange, and we should signify which is the important one.

I'd even say we should put the "What's new" right next to the other button.

What do you think?

[violoncelloCH]

It looks good, but could you also add class="primary" to the "Open updater" button? Because now the 2 same-looking buttons next to each other look a bit strange, and we should signify which is the important one.

of course, will do this

I'd even say we should put the "What's new" right next to the other button.

so we've got "Open updater" or "Download now" and "What's new" all in one row? should I change it like that? @jancborchardt

[violoncelloCH]

hmm, the "open updater" and "download now" buttons are inside a <p> which cannot include <div>s, but "what's new" needs <div>s...
I now changed the <p> to a <div> as well what should work. Hope this doesn't break something else

[jancborchardt]

Yes, I think having all buttons in one row looks better. With the most important action being on the left and with class="primary". Thanks a lot @violoncelloCH! :)

[skjnldsv]

Test restarted. Lots of unrelated timeouts

[MorrisJobke]

/backport to stable15

[backportbot-nextcloud]

The backport to stable15 failed. Please do this backport manually.

[skjnldsv]

Backport in #12848