Skip to content

Only run the AnonymousOptionsPlugion on Anonymous requests #12808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Dec 4, 2018
Merged

Only run the AnonymousOptionsPlugion on Anonymous requests #12808

rullzer merged 1 commit into from
Dec 4, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Dec 4, 2018 •
edited by kesselb
Loading

Fixes #12774

Signed-off-by: Roeland Jago Douma [email protected]

@rullzer rullzer added this to the Nextcloud 16 milestone Dec 4, 2018
@rullzer
Copy link
Member Author

rullzer commented Dec 4, 2018

/backport to stable15

@rullzer
Copy link
Member Author

rullzer commented Dec 4, 2018

/backport to stable14

MorrisJobke
MorrisJobke approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works again on macOS 👍

georgehrke
georgehrke approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes Fantastical 👍

@MorrisJobke MorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Dec 4, 2018
@MorrisJobke
Copy link
Member

MorrisJobke commented Dec 4, 2018

@rullzer Should we then release a 14.0.5 a bit ahead of time due to this?

@rullzer
Copy link
Member Author

rullzer commented Dec 4, 2018

@MorrisJobke 14.0.4 is not affected. This was merged shortly after. So no need.

@MorrisJobke
Copy link
Member

MorrisJobke commented Dec 4, 2018

@MorrisJobke 14.0.4 is not affected. This was merged shortly after. So no need.

Puh - luckily.

@wobben
Copy link

wobben commented Dec 4, 2018

great, iCal/macOS Mojave is working again!

@rullzer rullzer merged commit 43cb51d into master Dec 4, 2018
@rullzer rullzer deleted the fix/12774/anonymous_options_only_anoynoums branch December 4, 2018 12:10
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 4, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 4, 2018

backport to stable15 in #12811

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 4, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 4, 2018

backport to stable14 in #12812

@mp1409 mp1409 mentioned this pull request Dec 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@georgehrke georgehrke georgehrke approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug high regression

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

6 participants

@rullzer @MorrisJobke @wobben @georgehrke @icewind1991