No user enumeration on DAV if disabled #12814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Was merged. |
Fixes #9058 If the option to autocomplete users is disabled. We also should not enumerate the users on this endpoint. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
fix/9058/no_user_enumartion_if_disabled
branch
from
1538b07 to
58ca6b1
Compare
ChristophWurst
approved these changes
Dec 4, 2018
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Code looks good, change makes sense!
nickvergessen
approved these changes
Dec 5, 2018
Member
Author
|
/backport to stable15 |
|
backport to stable15 in #12856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you disable the
Allow username autocompletion in share dialog. If this is disabled the full username or email address needs to be entered.(share options)Then we should also not allow enumeration on this endpoint.
Fixes #9058
Depends on: