Fix layout of "i" in admin settings of federated sharing #12823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
added
bug
design
MorrisJobke
requested review from
ChristophWurst,
jancborchardt,
juliusknorr,
kesselb,
rullzer and
skjnldsv
Member
Author
|
/backport to stable15 |
jancborchardt
approved these changes
Dec 4, 2018
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks much better, thanks!
MorrisJobke
added
4. to release
|
backport to stable15 in #12829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the "i" out of the
<h2>(like all others) and centers it a bit better.I did this together with @jancborchardt while do the polishing review (#12694)
cc @nextcloud/designers
Before and after: