-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add setup check for pending bigint conversion #12824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup check for pending bigint conversion #12824
Conversation
|
/backport to stable15 |
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code make sense!
I did not even know we had db:convert-filecache-bigint :)
Signed-off-by: Morris Jobke <[email protected]>
* on SQLite primary keys can't be bigint - see https://stackoverflow.com/a/18835967/520507 Signed-off-by: Morris Jobke <[email protected]>
e828def to
772b6fc
Compare
|
@danielkesselberg I rebased this branch now and it is ready for review :) |
And this is the reason I added this 😆 |
|
@rullzer @ChristophWurst @nickvergessen Mind to review this one? |
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Code looks good, thanks for the tip of reviewing commit per commit 🤓
CI not happy 💥 |
Signed-off-by: Morris Jobke <[email protected]>
772b6fc to
17b2827
Compare
Fixed 🙈 |
|
This one looks suspicious https://drone.nextcloud.com/nextcloud/server/13349/267 (though feature is unrelated) The other failing acceptance tests seem to have timed out. |
Looks fine and happened on other PRs as well. |
|
backport to stable15 in #12853 |
Requires:
This contains multiple changes, that are best reviewed on a per commit basis:
This is how it looks like: