Skip to content

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Dec 4, 2018

Requires:

This contains multiple changes, that are best reviewed on a per commit basis:

This is how it looks like:

bildschirmfoto 2018-12-04 um 18 46 27

bildschirmfoto 2018-12-04 um 18 47 10

@MorrisJobke
Copy link
Member Author

/backport to stable15

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense!
I did not even know we had db:convert-filecache-bigint :)

* on SQLite primary keys can't be bigint - see https://stackoverflow.com/a/18835967/520507

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke force-pushed the feature/12763/add-setup-check-for-bigint-conversion branch from e828def to 772b6fc Compare December 4, 2018 23:35
@MorrisJobke
Copy link
Member Author

@danielkesselberg I rebased this branch now and it is ready for review :)

@MorrisJobke
Copy link
Member Author

Code make sense!
I did not even know we had db:convert-filecache-bigint :)

And this is the reason I added this 😆

@MorrisJobke
Copy link
Member Author

@rullzer @ChristophWurst @nickvergessen Mind to review this one?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Code looks good, thanks for the tip of reviewing commit per commit 🤓

@kesselb
Copy link
Contributor

kesselb commented Dec 5, 2018

TypeError: undefined is not an object (evaluating 'data.pendingBigIntConversionColumns.length') in core/js/setupchecks.js (line 9)

CI not happy 💥

@MorrisJobke MorrisJobke force-pushed the feature/12763/add-setup-check-for-bigint-conversion branch from 772b6fc to 17b2827 Compare December 5, 2018 12:42
@MorrisJobke
Copy link
Member Author

CI not happy 💥

Fixed 🙈

@MorrisJobke MorrisJobke mentioned this pull request Dec 5, 2018
12 tasks
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 5, 2018
@ChristophWurst
Copy link
Member

This one looks suspicious https://drone.nextcloud.com/nextcloud/server/13349/267 (though feature is unrelated)

The other failing acceptance tests seem to have timed out.

@MorrisJobke
Copy link
Member Author

This one looks suspicious https://drone.nextcloud.com/nextcloud/server/13349/267 (though feature is unrelated)

Looks fine and happened on other PRs as well.

@MorrisJobke MorrisJobke merged commit fe58137 into master Dec 5, 2018
@MorrisJobke MorrisJobke deleted the feature/12763/add-setup-check-for-bigint-conversion branch December 5, 2018 17:53
@backportbot-nextcloud
Copy link

backport to stable15 in #12853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add setup check for missing bigint conversion

5 participants