Deprecate \OC_Util::getEditionString()

apps/files_sharing/templates/public.php

@@ -43,13 +43,7 @@
 
 		<div class="header-appname-container">
 			<h1 class="header-appname">
-				<?php
-					if(OC_Util::getEditionString() === '') {
-						p($theme->getName());
-					} else {
-						print_unescaped($theme->getHTMLName());
-					}
-				?>
+				<?php p($theme->getName()); ?>
 			</h1>
 		</div>
 

core/Command/Status.php

@@ -38,13 +38,11 @@ protected function configure() {
 	}
 
 	protected function execute(InputInterface $input, OutputInterface $output) {
-		$installed = (bool) \OC::$server->getConfig()->getSystemValue('installed', false);
-
 		$values = array(
-			'installed' => $installed,
+			'installed' => (bool) \OC::$server->getConfig()->getSystemValue('installed', false),
 			'version' => implode('.', \OCP\Util::getVersion()),
 			'versionstring' => \OC_Util::getVersionString(),
-			'edition' => $installed ? \OC_Util::getEditionString() : '',
+			'edition' => '',
 		);
 
 		$this->writeArrayInOutputFormat($input, $output, $values);

core/Controller/OCSController.php

@@ -81,7 +81,7 @@ public function getCapabilities() {
 			'minor' => $minor,
 			'micro' => $micro,
 			'string' => \OC_Util::getVersionString(),
-			'edition' => \OC_Util::getEditionString(),
+			'edition' => '',
 		);
 
 		$result['capabilities'] = $this->capabilitiesManager->getCapabilities();

core/templates/layout.user.php

@@ -48,13 +48,7 @@
 
 			<a href="#" class="header-appname-container menutoggle" tabindex="2">
 				<h1 class="header-appname">
-					<?php
-						if(OC_Util::getEditionString() === '') {
-							p(!empty($_['application'])?$_['application']: $l->t('Apps'));
-						} else {
-							print_unescaped($theme->getHTMLName());
-						}
-					?>
+					<?php p(!empty($_['application'])?$_['application']: $l->t('Apps')); ?>
 				</h1>
 				<div class="icon-caret"></div>
 			</a>

lib/private/OCSClient.php

@@ -70,13 +70,7 @@ public function __construct(IClientService $httpClientService,
 	 * @return bool
 	 */
 	public function isAppStoreEnabled() {
-		// For a regular edition default to true, all others default to false
-		$default = false;
-		if (\OC_Util::getEditionString() === '') {
-			$default = true;
-		}
-
-		return $this->config->getSystemValue('appstoreenabled', $default) === true;
+		return $this->config->getSystemValue('appstoreenabled', true) === true;
 	}
 
 	/**

lib/private/Updater/VersionCheck.php

@@ -71,7 +71,7 @@ public function check() {
 		$version['installed'] = $this->config->getAppValue('core', 'installedat');
 		$version['updated'] = $this->config->getAppValue('core', 'lastupdatedat');
 		$version['updatechannel'] = \OC_Util::getChannel();
-		$version['edition'] = \OC_Util::getEditionString();
+		$version['edition'] = '';
 		$version['build'] = \OC_Util::getBuild();
 		$versionString = implode('x', $version);
 

lib/private/legacy/app.php

@@ -437,9 +437,7 @@ public static function getSettingsNavigation() {
 
 		$settings = array();
 		// by default, settings only contain the help menu
-		if (OC_Util::getEditionString() === '' &&
-			\OC::$server->getSystemConfig()->getValue('knowledgebaseenabled', true) == true
-		) {
+		if (\OC::$server->getSystemConfig()->getValue('knowledgebaseenabled', true)) {
 			$settings = array(
 				array(
 					"id" => "help",

lib/private/legacy/util.php

@@ -382,18 +382,11 @@ public static function getVersionString() {
 	}
 
 	/**
-	 * @description get the current installed edition of ownCloud. There is the community
-	 * edition that just returns an empty string and the enterprise edition
-	 * that returns "Enterprise".
+	 * @deprecated the value is of no use anymore
 	 * @return string
 	 */
 	public static function getEditionString() {
-		if (OC_App::isEnabled('enterprise_key')) {
-			return "Enterprise";
-		} else {
-			return "";
-		}
-
+		return '';
 	}
 
 	/**

settings/Controller/CheckSetupController.php

@@ -174,19 +174,13 @@ protected function getCurlVersion() {
 	 * @return string
 	 */
 	private function isUsedTlsLibOutdated() {
-		// Appstore is disabled by default in EE
-		$appStoreDefault = false;
-		if (\OC_Util::getEditionString() === '') {
-			$appStoreDefault = true;
-		}
-
 		// Don't run check when:
 		// 1. Server has `has_internet_connection` set to false
 		// 2. AppStore AND S2S is disabled
 		if(!$this->config->getSystemValue('has_internet_connection', true)) {
 			return '';
 		}
-		if(!$this->config->getSystemValue('appstoreenabled', $appStoreDefault)
+		if(!$this->config->getSystemValue('appstoreenabled', true)
 			&& $this->config->getAppValue('files_sharing', 'outgoing_server2server_share_enabled', 'yes') === 'no'
 			&& $this->config->getAppValue('files_sharing', 'incoming_server2server_share_enabled', 'yes') === 'no') {
 			return '';
@@ -200,7 +194,7 @@ private function isUsedTlsLibOutdated() {
 		}
 
 		$features = (string)$this->l10n->t('installing and updating apps via the app store or Federated Cloud Sharing');
-		if(!$this->config->getSystemValue('appstoreenabled', $appStoreDefault)) {
+		if(!$this->config->getSystemValue('appstoreenabled', true)) {
 			$features = (string)$this->l10n->t('Federated Cloud Sharing');
 		}
 

settings/templates/personal.php

@@ -157,12 +157,10 @@
 			</option>
 		<?php endforeach;?>
 	</select>
-	<?php if (OC_Util::getEditionString() === ''): ?>
 	<a href="https://www.transifex.com/nextcloud/nextcloud/"
 		target="_blank" rel="noreferrer">
 		<em><?php p($l->t('Help translate'));?></em>
 	</a>
-	<?php endif; ?>
 </form>
 
 
@@ -181,7 +179,6 @@
 			 alt="<?php p($l->t('iOS app'));?>" />
 	</a>
 
-	<?php if (OC_Util::getEditionString() === ''): ?>
 		<p>
 			<?php print_unescaped($l->t('If you want to support the project
 		<a href="https://nextcloud.com/contribute"
@@ -190,7 +187,6 @@
 		<a href="https://nextcloud.com/contribute"
 			target="_blank" rel="noreferrer">spread the word</a>!'));?>
 		</p>
-	<?php endif; ?>
 
 	<?php if(OC_APP::isEnabled('firstrunwizard')) {?>
 		<p><a class="button" href="#" id="showWizard"><?php p($l->t('Show First Run Wizard again'));?></a></p>

settings/templates/settings.development.notice.php

@@ -1,4 +1,3 @@
-<?php if (OC_Util::getEditionString() === ''): ?>
 	<p>
 		<?php print_unescaped(str_replace(
 			[
@@ -63,5 +62,3 @@
 {newsletteropen}<img width="50" src="{mailimage}" title="{mailtext}" alt="{mailtext}">{linkclose}'
 		)); ?>
 	</p>
-
-<?php endif; ?>

status.php

@@ -43,7 +43,7 @@
 		'maintenance' => $maintenance,
 		'version'=>implode('.', \OCP\Util::getVersion()),
 		'versionstring'=>OC_Util::getVersionString(),
-		'edition'=> $installed ? OC_Util::getEditionString() : '',
+		'edition'=> '',
 		'productname'=>$defaults->getName());
 	if (OC::$CLI) {
 		print_r($values);

tests/Settings/Controller/CheckSetupControllerTest.php

@@ -508,12 +508,6 @@ public function testIsUsedTlsLibOutdatedWithInternetDisabled() {
 	}
 
 	public function testIsUsedTlsLibOutdatedWithAppstoreDisabledAndServerToServerSharingEnabled() {
-		// Appstore is disabled by default in EE
-		$appStoreDefault = false;
-		if (\OC_Util::getEditionString() === '') {
-			$appStoreDefault = true;
-		}
-
 		$this->config
 			->expects($this->at(0))
 			->method('getSystemValue')
@@ -522,7 +516,7 @@ public function testIsUsedTlsLibOutdatedWithAppstoreDisabledAndServerToServerSha
 		$this->config
 			->expects($this->at(1))
 			->method('getSystemValue')
-			->with('appstoreenabled', $appStoreDefault)
+			->with('appstoreenabled', true)
 			->will($this->returnValue(false));
 		$this->config
 			->expects($this->at(2))
@@ -543,12 +537,6 @@ public function testIsUsedTlsLibOutdatedWithAppstoreDisabledAndServerToServerSha
 	}
 
 	public function testIsUsedTlsLibOutdatedWithAppstoreDisabledAndServerToServerSharingDisabled() {
-		// Appstore is disabled by default in EE
-		$appStoreDefault = false;
-		if (\OC_Util::getEditionString() === '') {
-			$appStoreDefault = true;
-		}
-
 		$this->config
 			->expects($this->at(0))
 			->method('getSystemValue')
@@ -557,7 +545,7 @@ public function testIsUsedTlsLibOutdatedWithAppstoreDisabledAndServerToServerSha
 		$this->config
 			->expects($this->at(1))
 			->method('getSystemValue')
-			->with('appstoreenabled', $appStoreDefault)
+			->with('appstoreenabled', true)
 			->will($this->returnValue(false));
 		$this->config
 			->expects($this->at(2))

tests/lib/Updater/VersionCheckTest.php

@@ -50,7 +50,7 @@ public function setUp() {
 	 * @return string
 	 */
 	private function buildUpdateUrl($baseUrl) {
-		return $baseUrl . '?version='.implode('x', Util::getVersion()).'xinstalledatxlastupdatedatx'.\OC_Util::getChannel().'x'.\OC_Util::getEditionString().'x';
+		return $baseUrl . '?version='.implode('x', Util::getVersion()).'xinstalledatxlastupdatedatx'.\OC_Util::getChannel().'xx';
 	}
 
 	public function testCheckInCache() {

tests/lib/UpdaterTest.php

@@ -61,7 +61,7 @@ public function setUp() {
 	 * @return string
 	 */
 	private function buildUpdateUrl($baseUrl) {
-		return $baseUrl . '?version='.implode('x', \OCP\Util::getVersion()).'xinstalledatxlastupdatedatx'.\OC_Util::getChannel().'x'.\OC_Util::getEditionString().'x';
+		return $baseUrl . '?version='.implode('x', \OCP\Util::getVersion()).'xinstalledatxlastupdatedatx'.\OC_Util::getChannel().'xx';
 	}
 
 	/**