Skip to content

Log and continue on Dav reader failure (repair uid) #12854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Dec 5, 2018
Merged

Log and continue on Dav reader failure (repair uid) #12854

MorrisJobke merged 1 commit into from
Dec 5, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 5, 2018 •
edited
Loading

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews high labels Dec 5, 2018
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Dec 5, 2018
@skjnldsv skjnldsv self-assigned this Dec 5, 2018
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 5, 2018

/backport to stable15

@skjnldsv skjnldsv changed the title Log and continue on Dav reader failure Log and continue on Dav reader failure (repair uid) Dec 5, 2018
ChristophWurst
ChristophWurst reviewed Dec 5, 2018
View reviewed changes
ChristophWurst
ChristophWurst requested changes Dec 5, 2018
View reviewed changes
kesselb
kesselb reviewed Dec 5, 2018
View reviewed changes
ChristophWurst
ChristophWurst requested changes Dec 5, 2018
View reviewed changes
ChristophWurst
ChristophWurst approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 5, 2018 •
edited
Loading

BTW, we fixed this, but any REPORT request to the addressbook containing this vcard will fail. So in the end This is not really great! This is a fix to a problem that should not have happened 😕

@georgehrke should we have an autofix for the vcards? What to do on that case? Any clue?
Should we warn the user?

@skjnldsv skjnldsv requested a review from georgehrke December 5, 2018 19:35
@MorrisJobke MorrisJobke mentioned this pull request Dec 5, 2018
Merged
12 tasks
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 5, 2018
@skjnldsv
Log and continue on Dav reader failure
2be63bc 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the vcard-repair-uid-fix branch from 619968a to 2be63bc Compare December 5, 2018 20:14
@MorrisJobke MorrisJobke merged commit e808661 into master Dec 5, 2018
@MorrisJobke MorrisJobke deleted the vcard-repair-uid-fix branch December 5, 2018 21:54
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 5, 2018
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Dec 5, 2018

backport to stable15 in #12867

@georgehrke
Copy link
Member

georgehrke commented Dec 6, 2018

@skjnldsv The corresponding function in the CalDAV backend always catches Exceptions: https://github.com/nextcloud/server/blob/v15.0.0RC2/apps/dav/lib/CalDAV/CalDavBackend.php#L1346L1360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug high

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv @georgehrke @ChristophWurst @kesselb @MorrisJobke