Skip to content

Added Drozone to favorites quickaccess #12917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 12 commits into from
Feb 1, 2019
Merged

Added Drozone to favorites quickaccess #12917

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2aee19a
Remove hack to prefetch the starred trash icon
danxuliu Jan 31, 2019
47937a5
Remove leftover from a WIP
danxuliu Jan 31, 2019
dd91c4e
Remove duplicated variable declaration
danxuliu Jan 31, 2019
72a424d
Remove unneeded triggering of event
danxuliu Jan 31, 2019
96bc139
Add missing trailing ";"
danxuliu Jan 31, 2019
75edcad
Replace double quotes with single quotes
danxuliu Jan 31, 2019
3baa078
Make code format more consistent with the rest of the file
danxuliu Jan 31, 2019
e46a67e
Use full names instead of abbreviations in variable names
danxuliu Jan 31, 2019
8680ced
Unify handling of dropping one file or several files on the trash bin
danxuliu Jan 31, 2019
ad407f6
Fix drop zone shadow
newhinton Dec 7, 2018
4b32e1c
Extract variable for yellow color in icons
newhinton Dec 7, 2018
f13b3ab
Add drop zone for favorites quick access in navigation
newhinton Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove hack to prefetch the starred trash icon 
Since 6ad7f32 SVG icons are directly embedded in "icons-vars.css", so
the starred trash icon is now loaded along with the regular trash icon
all at once. Therefore it is not needed to explicitly prefetch it using
a hidden div.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Jan 31, 2019
commit 2aee19a4ba664ad826f1e15fc78a82099e6da1d8
3 changes: 0 additions & 3 deletions apps/files/js/navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@
this.$el.on('click', 'li button', _.bind(this._onClickMenuButton, this));

var trashElement=$(".nav-trashbin");

//this div is required to prefetch the icon, otherwise it takes a second to show up
trashElement.append("<div class='nav-icon-trashbin-starred'></div>")
trashElement.droppable({
over: function( event, ui ) {
trashElement.addClass('dropzone-background')
Expand Down