Skip to content

add support for boolean default #12969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jan 9, 2019
Merged

add support for boolean default #12969

nickvergessen merged 1 commit into from
Jan 9, 2019

Conversation

@ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Dec 10, 2018

if String, we add the quotes.
if Boolean, we just convert to string with no quote.
if else (numeric) we don't do anything

@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Dec 10, 2018
kesselb
kesselb reviewed Jan 4, 2019
View reviewed changes
@kesselb
Copy link
Contributor

kesselb commented Jan 4, 2019

Before:

$table->addColumn('opened', 'boolean', [
	'notnull' => true,
	'default' => '1',
]);

After:

$table->addColumn('opened', 'boolean', [
	'notnull' => true,
	'default' => true,
]);

Tested with the news app 👍

@nickvergessen nickvergessen added this to the Nextcloud 16 milestone Jan 8, 2019
@nickvergessen
Copy link
Member

nickvergessen commented Jan 8, 2019

/backport to stable15

@nickvergessen
Copy link
Member

nickvergessen commented Jan 8, 2019

/backport to stable14

nickvergessen
nickvergessen reviewed Jan 8, 2019
View reviewed changes
@ArtificialOwl ArtificialOwl force-pushed the db-migration-boolean-default branch from c434620 to e947b3d Compare January 9, 2019 09:52
@ArtificialOwl @nickvergessen
add support for boolean default
8002779 
Signed-off-by: Maxence Lange <[email protected]>
code cleaning

Signed-off-by: Maxence Lange <[email protected]>
code cleaning

Signed-off-by: Maxence Lange <[email protected]>
@nickvergessen nickvergessen force-pushed the db-migration-boolean-default branch from e947b3d to 8002779 Compare January 9, 2019 10:21
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 9, 2019
@nickvergessen
Copy link
Member

nickvergessen commented Jan 9, 2019

Rebased, because drone exploded with the 7.0 tests

@nickvergessen nickvergessen merged commit b8bb1d4 into master Jan 9, 2019
@nickvergessen nickvergessen deleted the db-migration-boolean-default branch January 9, 2019 13:00
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 9, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 9, 2019

backport to stable15 in #13444

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 9, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 9, 2019

backport to stable14 in #13445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@kesselb kesselb kesselb approved these changes

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtificialOwl @kesselb @nickvergessen