Skip to content

Fix required permissions for webdav move and copy #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 3 commits into from
Sep 7, 2016
Merged

Fix required permissions for webdav move and copy #1301

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c0665b
Only require CREATE permissions when the file does not exist yet
nickvergessen Sep 7, 2016
cf69a2b
UPDATE permissions qualify for renaming a node
nickvergessen Sep 7, 2016
b94a4df
Fix tests
nickvergessen Sep 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Only require CREATE permissions when the file does not exist yet
  • Loading branch information
@nickvergessen
nickvergessen committed Sep 7, 2016
commit 4c0665b6ecff6e056de9020ee5d78b73a60134d1
13 changes: 11 additions & 2 deletions apps/dav/lib/Connector/Sabre/ObjectTree.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,11 @@ public function move($sourcePath, $destinationPath) {

$infoDestination = $this->fileView->getFileInfo(dirname($destinationPath));
$infoSource = $this->fileView->getFileInfo($sourcePath);
$destinationPermission = $infoDestination && $infoDestination->isUpdateable();
if ($this->fileView->file_exists($destinationPath)) {
$destinationPermission = $infoDestination && $infoDestination->isUpdateable();
} else {
$destinationPermission = $infoDestination && $infoDestination->isCreatable();
}
$sourcePermission = $infoSource && $infoSource->isDeletable();

if (!$destinationPermission || !$sourcePermission) {
Expand Down Expand Up @@ -298,7 +302,12 @@ public function copy($source, $destination) {


$info = $this->fileView->getFileInfo(dirname($destination));
if ($info && !$info->isUpdateable()) {
if ($this->fileView->file_exists($destination)) {
$destinationPermission = $info && $info->isUpdateable();
} else {
$destinationPermission = $info && $info->isCreatable();
}
if (!$destinationPermission) {
throw new Forbidden('No permissions to copy object.');
}

Expand Down