Where is your data? #13097

weeman1337 · 2018-12-16T17:42:58Z

For previous discussions also see #11319.

ToDo

personal settings layout improvement
settings input view

weeman1337 · 2018-12-16T17:52:08Z

That's what the front end looks so far:

For me it's hard to distinguish links and text as they're displayed the same. So I highlighted them with the primary color. I didn't find anything about that in the dev docs.

The "... is your admin" will have two ways for detection:

Any admin user if none was selected in the settings
The selected one from the settings

Any thoughts about that @nextcloud/designers ?

jancborchardt · 2018-12-17T14:40:15Z

Very nice! :)

We could think about using "border-bottom: 1px dotted text-color" for marking links. Let's do that separately though as this is something we need to generally fix, but it will need some adjustment (e.g. so text inside buttons which are a class="button" is not underlined)
For admins, it's simpler to use "… contact them." instead of "him/her". Works as singular and plural too if there's multiple admins.
@shironextcloud what do you think? :)

skjnldsv · 2018-12-17T16:01:20Z

I really like it!
I agree with Jan's suggestions. I would also add that the plug icon doesn't really make any sense. Maybe use a server icon?

weeman1337 · 2018-12-17T16:40:38Z

I would also add that the plug icon doesn't really make any sense

Fully agree. This is only a placeholder - I'm not happy with it, too.
Should I extend the NC icon set? Is there any free icon set I can take the icon from?

We could think about using "border-bottom: 1px dotted text-color" for marking links.

✓ will do that

For admins, it's simpler to use "… contact them." instead of "him/her". Works as singular and plural too if there's multiple admins.

@jancborchardt do you suggest listing all admin users then? I thought about picking one of the admins and in addition give the option to define a specific one in the settings.

skjnldsv · 2018-12-17T16:43:14Z

@jancborchardt do you suggest listing all admin users then? I thought about picking one of the admins and in addition give the option to define a specific one in the settings.

That is one issue we have with the preferred provider program.
There is no official setting to define a 'contact' for a nextcloud instance. It could be a nice addition :)

shironextcloud · 2018-12-17T19:18:45Z

* For admins, it's simpler to use "… contact them." instead of "him/her". Works as singular and plural too if there's multiple admins.

* @shironextcloud what do you think? :)

agree on "them"

really nice :)

weeman1337 · 2018-12-18T18:50:46Z

@nextcloud/designers regarding links, here are the two dotted options:

Where the text-decoration way looks cleaner on the whole, border-bottom is easier to read.

weeman1337 · 2018-12-18T20:00:58Z

Here is the settings view:

I placed it in the "Basic settings" at the bottom.

skjnldsv · 2018-12-18T20:03:27Z

It looks amazing!!!
Can I be peaky and ask the loader to be on the button to save the form? 🙈 We tend to do that in most of the places and looks better imho. Not that big of a deal though ;)

I prefer the border bottom for the design. Better looking. More aerated :)

weeman1337 · 2018-12-18T20:15:04Z

Can I be peaky and ask the loader to be on the button to save the form? see_no_evil We tend to do that in most of the places and looks better imho. Not that big of a deal though ;)

@skjnldsv jep - fine for me. Can you give me an example, so I can have a look copy the style.

There is also some feedback (I took it from the settings above). Does anything common exist for that, too?

skjnldsv · 2018-12-18T20:17:59Z

Could be nice to have a standard actually! I don't think we really have one yet! 🤔
You know what, I'll let you decide! We could then make sure to have the new standard in as many places as we can on the settings! 🚀 🙇‍♂️

weeman1337 · 2018-12-18T21:04:53Z

@skjnldsv what about this:

skjnldsv · 2018-12-18T21:10:42Z

I really like it!! 🎉 😍
Some quick thinking:

I would actually make sure the size does not change that much, because it's confusing to the user.
I would also not use an input since the loader cannot work (fallback to gif since no pseudo-elements can be applied on an inline element) Use a label to link the action to the input! 😉
No need for the ... since the loader already give a progress state
I would use an icon by default for the save button. It draws attention and would also prevent your button from moving too much when switching from "save" to "saving" since the loader width would already be taken by the icon

I'm sure @jancborchardt will have some insights as well!

weeman1337 · 2018-12-19T22:20:44Z

Update today: the server info is now stored and loaded.

I put the info into the config. Why?: My idea is if you deploy an instance you can simply put it into the file. If anyone thinks it should be a db setting, let me know.

The funky save button also got an update: The spinner shows with 1s delay to prevent unnecessary flickering. It says "saved" until you change any form value. Works fine so far. With another icon for the default state ("save") it doesn't jump that much.

jancborchardt · 2018-12-20T00:16:32Z

Agree with what @skjnldsv said, some additional feedback:

Buttons should usually go on the right, but being aligned with the fields seems good too, and the size switching will be less strange since the icon and the start of the text will always stay
The Save button should have class="primary" to appear blue
"Saving" and "Saved" states should have a capital first letter
The placeholders of the input fields should also have a capital first letter
For the "Website" and "Link to privacy policy" fields, the placeholder should be "https://…"
Actually thinking about it: Shouldn’t the company/instance name, website link and privacy policy link be taken from Theming, where we already have that info? cc @juliushaertl
Let’s use border-bottom for the links for now. We have to do this generally in the server but this is a good start. (Please make sure to prefix it so it only changes the link styles in this specific container)

If there is no data put in for one of the parts yet, like the server location for example, that part should simply not be shown in the list.

Awesome work @weeman1337! 🎉

jancborchardt · 2018-12-20T00:19:08Z

Sorry, forgot to answer your question. For the provider icon, simply use icon-home:

https://docs.nextcloud.com/server/15/developer_manual/design/icons.html

weeman1337 · 2018-12-21T19:19:10Z

Actually thinking about it: Shouldn’t the company/instance name, website link and privacy policy link be taken from Theming, where we already have that info?

Yes, I see some of the info is already there. Having it redundant doesn't make sense. I think "name" in theming is more the instance name. So missing is "server location", "provider name" and "admin contact". I could also add these fields to the theming section. @nextcloud/designers ¯\_(ツ)_/¯

jancborchardt · 2018-12-21T22:23:53Z

I could also add these fields to the theming section.

Not sure if this makes sense. Thinking about it though … Mastodon for example also shows the instance admin in more public places like the home page (and Discourse also has a page for it), and server location is something we could even show in the footer (just an idea, probably too much info) so it would indeed be more related to general theming. @juliushaertl what do you think?

Let’s just make sure that we do it step by step. And the first step is to just not duplicate info we already have in theming. :)

weeman1337 · 2018-12-29T10:06:58Z

Ping @juliushaertl - waiting for a response where to put the fields..

skjnldsv · 2019-01-08T11:00:56Z

I think there should be a dedicated option to it. Theming is design only, nothing related to administration or mails should go there I think :)

jancborchardt · 2019-01-09T01:35:07Z

Theming is design only, nothing related to administration or mails should go there I think :)

That’s not true though. ;) This is the one place where you set things like the instance name, link, privacy policy & terms links etc. These are used across the app, including in emails and such. It’s good that it’s only this one place, and hence the things we need for "Who Owns Your Data" should also either be pulled from there, or if it extends it, be added there.

@weeman1337 the Unsplash app also adds a section in the Theming settings, maybe you can check that out?

MariusBluem · 2019-01-09T09:04:26Z

„Your Data is protected by“ should be changed to „Your Files are encrypted with“ since

encryption is only about files and not about all data (maybe we should clarify this even more)
encrypted is more neutral than protect

Signed-off-by: Michael Weimann <[email protected]>

MariusBluem · 2019-01-20T10:36:09Z

@MariusBluem I've updated the wording:

Thanks 👍

What do you think about "About this server" instead of "Where is your data?"? @nextcloud/designers

jancborchardt · 2019-01-23T17:07:00Z

@MariusBluem I’d say let’s do any further changes in follow-up pull requests. :) The "Where is your data?" is direct and nice.

cc @nextcloud/javascript @nextcloud/designers for review as well 🙂

MorrisJobke

Tested and works 👍

The only minor part that would be nice to be fixed is that if there is nothing specified also the header should not be shown:

skjnldsv

See Morris's comment :)

Signed-off-by: Michael Weimann <[email protected]>

weeman1337 · 2019-01-29T18:43:44Z

@skjnldsv the section is now optional.

MorrisJobke

Tested and works 👍

kesselb

😎 Some code style and we're done ;-)

kesselb · 2019-02-05T16:01:36Z

lib/private/Settings/Personal/PersonalInfo.php

+	 *
+	 * @return array
+	 */
+	private function getWhereIsYourDataParams() {


typehint array

kesselb · 2019-02-05T16:03:40Z

lib/private/Settings/Theming/ServerInfo.php

+	 *
+	 * @return string
+	 */
+	public function getSection() {


return type string

kesselb · 2019-02-05T16:03:55Z

lib/private/Settings/Theming/ServerInfo.php

+	 * the admin section. The forms are arranged in ascending order of the
+	 * priority values. It is required to return a value between 0 and 100.
+	 */
+	public function getPriority() {


return type int

lib/private/Settings/Theming/ServerInfo.php

settings/Controller/ServerInfoSettingsController.php

kesselb · 2019-02-05T18:07:46Z

settings/templates/settings/personal/partials/where-is-your-data.php

+			<?php echo $l->t(
+				'%s%s%s is your admin. If you have any issues, %scontact them%s.',
+				[
+					'<a href="mailto:' . $_['adminMail'] . '" target="_blank" title="" rel="noreferrer noopener">',


In theory there could be an admin account without email. I guess we could ignore that for now.

lib/private/Settings/Personal/PersonalInfo.php

georgehrke · 2019-02-06T12:04:02Z

@weeman1337 I actually developed something very similar lately, but as an independent app instead of putting it into the server.

I have to two fix some minor issues and will push it to a repository tonight.
Maybe we can merge our efforts together? :)

weeman1337 · 2019-02-06T12:21:28Z

@georgehrke thanks for the info. So that will be the official "where is my data" app?

That would mean this PR is obsolete?

MorrisJobke · 2019-02-06T12:49:25Z

@georgehrke thanks for the info. So that will be the official "where is my data" app?

That would mean this PR is obsolete?

I would not say so. I would like to have this as it is in this PR. Then we can think on how to integrate both of them into one interface. The problem here was that @karlitschek was not aware of this PR and asked @georgehrke to do it in an app.

karlitschek · 2019-02-06T22:10:32Z

Yes. It's totally my fault that I wasn't aware of the duplicate work. Sorry. Not sure what the best way is to proceed. Whatever you suggest. @MorrisJobke @weeman1337 @georgehrke

MorrisJobke · 2019-02-07T13:38:18Z

@georgehrke @weeman1337 I would get this PR here in because it is fully working and was tested already. Also the design team had a look at it and it's approved. We then can check out how to combine or integrate it with your approach because you feature a lot more context due to the user data manifesto.

MorrisJobke · 2019-02-07T13:38:34Z

@skjnldsv @danielkesselberg @georgehrke @rullzer Please review.

Signed-off-by: Michael Weimann <[email protected]>

kesselb · 2019-02-10T09:57:03Z

lib/private/Settings/Personal/PersonalInfo.php

 use OCP\IUserManager;
 use OCP\L10N\IFactory;
 use OCP\Settings\ISettings;
+use OCP\Encryption\IManager as EncryptionManager;


IEncryptionManager would be more clear here.

Let's do this later as well together with the email check.

weeman1337 added enhancement 2. developing Work in progress feature: settings labels Dec 16, 2018

weeman1337 added this to the Nextcloud 16 milestone Dec 16, 2018

weeman1337 self-assigned this Dec 16, 2018

weeman1337 mentioned this pull request Dec 16, 2018

Where is your data? #11319

Closed

weeman1337 added the design Design, UI, UX, etc. label Dec 16, 2018

weeman1337 force-pushed the feature/11319/where-is-your-data branch from f4f17f3 to 54ac94a Compare December 18, 2018 21:08

weeman1337 requested review from MariusBluem, juliusknorr, rullzer and skjnldsv January 20, 2019 10:15

weeman1337 added 2 commits January 20, 2019 11:23

Update provider icon

5712997

Signed-off-by: Michael Weimann <[email protected]>

Remove debug setting

b8d25a1

Signed-off-by: Michael Weimann <[email protected]>

MorrisJobke reviewed Jan 28, 2019

View reviewed changes

skjnldsv requested changes Jan 29, 2019

View reviewed changes

Make the where is your data section optional

6c52821

Signed-off-by: Michael Weimann <[email protected]>

MorrisJobke approved these changes Jan 30, 2019

View reviewed changes

MorrisJobke requested review from ChristophWurst and kesselb February 5, 2019 11:18

kesselb requested changes Feb 5, 2019

View reviewed changes

Code style and comment fixes

587a140

Signed-off-by: Michael Weimann <[email protected]>

kesselb approved these changes Feb 10, 2019

View reviewed changes

kesselb reviewed Feb 10, 2019

View reviewed changes

MorrisJobke merged commit 34dc165 into master Feb 11, 2019

MorrisJobke deleted the feature/11319/where-is-your-data branch February 11, 2019 10:15

MorrisJobke mentioned this pull request Feb 27, 2019

Do not register unexisting section #14402

Merged

MorrisJobke mentioned this pull request Mar 18, 2019

How to merge "Where is your data?" and privacy app #14738

Closed

rullzer mentioned this pull request Mar 19, 2019

Revert "Where is your data?" #14753

Merged

Uh oh!

Where is your data? #13097

Where is your data? #13097

Uh oh!

Conversation

weeman1337 commented Dec 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weeman1337 commented Dec 16, 2018

Uh oh!

jancborchardt commented Dec 17, 2018

Uh oh!

skjnldsv commented Dec 17, 2018

Uh oh!

weeman1337 commented Dec 17, 2018

Uh oh!

skjnldsv commented Dec 17, 2018

Uh oh!

shironextcloud commented Dec 17, 2018

Uh oh!

weeman1337 commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weeman1337 commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skjnldsv commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weeman1337 commented Dec 18, 2018

Uh oh!

skjnldsv commented Dec 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weeman1337 commented Dec 18, 2018

Uh oh!

skjnldsv commented Dec 18, 2018

Uh oh!

weeman1337 commented Dec 19, 2018

Uh oh!

jancborchardt commented Dec 20, 2018 • edited by weeman1337 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jancborchardt commented Dec 20, 2018

Uh oh!

weeman1337 commented Dec 21, 2018

Uh oh!

jancborchardt commented Dec 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weeman1337 commented Dec 29, 2018

Uh oh!

skjnldsv commented Jan 8, 2019

Uh oh!

jancborchardt commented Jan 9, 2019

Uh oh!

MariusBluem commented Jan 9, 2019

Uh oh!

MariusBluem commented Jan 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jancborchardt commented Jan 23, 2019

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

skjnldsv left a comment

Choose a reason for hiding this comment

Uh oh!

weeman1337 commented Jan 29, 2019

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

kesselb left a comment

Choose a reason for hiding this comment

Uh oh!

kesselb Feb 5, 2019

Choose a reason for hiding this comment

Uh oh!

weeman1337 commented Dec 16, 2018 •

edited

Loading

weeman1337 commented Dec 18, 2018 •

edited

Loading

weeman1337 commented Dec 18, 2018 •

edited

Loading

skjnldsv commented Dec 18, 2018 •

edited

Loading

skjnldsv commented Dec 18, 2018 •

edited

Loading

jancborchardt commented Dec 20, 2018 •

edited by weeman1337

Loading

jancborchardt commented Dec 21, 2018 •

edited

Loading

MariusBluem commented Jan 20, 2019 •

edited

Loading