Skip to content

Conversation

@skjnldsv
Copy link
Member

@nextcloud/designers

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews 15-feedback labels Dec 18, 2018
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Dec 18, 2018
@skjnldsv skjnldsv self-assigned this Dec 18, 2018
@skjnldsv
Copy link
Member Author

/backport to stable15

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it works, but there is a minor issue:

  • Resize the window (or install a lot of apps ;-) ) so the More item is shown
  • Click on More
  • Click anywhere else (except on More itself) to hide again the menu
  • Hover on other app icon

Expected result:
The name is shown for the app

Actual result:
The name is hidden

@skjnldsv
Copy link
Member Author

@danxuliu I'd rather have this then. IE experience is reduced anyway by other incompatible features. So I'd guess sooner or later we'll have different things like that :)

@danxuliu
Copy link
Member

I'd rather have this then. IE experience is reduced anyway by other incompatible features. So I'd guess sooner or later we'll have different things like that :)

Sure, but in this case it is not a different behaviour, but a bug ;-) Anyway I am OK with merging it in its current state, that is why I added it as a comment instead of as a request for changes ;-)

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

@rullzer Mind to give a review?

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 4, 2019
@MorrisJobke MorrisJobke merged commit f736b34 into master Jan 4, 2019
@MorrisJobke MorrisJobke deleted the ie11-apps-menu-fix branch January 4, 2019 18:30
@backportbot-nextcloud
Copy link

backport to stable15 in #13361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants