-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
IE fix for apps menu #13145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE fix for apps menu #13145
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
|
/backport to stable15 |
danxuliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it works, but there is a minor issue:
- Resize the window (or install a lot of apps ;-) ) so the More item is shown
- Click on More
- Click anywhere else (except on More itself) to hide again the menu
- Hover on other app icon
Expected result:
The name is shown for the app
Actual result:
The name is hidden
|
@danxuliu I'd rather have this then. IE experience is reduced anyway by other incompatible features. So I'd guess sooner or later we'll have different things like that :) |
Sure, but in this case it is not a different behaviour, but a bug ;-) Anyway I am OK with merging it in its current state, that is why I added it as a comment instead of as a request for changes ;-) |
MorrisJobke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
|
@rullzer Mind to give a review? |
rullzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
|
backport to stable15 in #13361 |
@nextcloud/designers