Skip to content

Use npm for js depdencies, bundle with webpack #13156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 14 commits into from
Jan 9, 2019
Merged

Use npm for js depdencies, bundle with webpack #13156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2087881
Npmize (vendor) scripts
ChristophWurst Dec 11, 2018
6da13f8
Remove Bower
ChristophWurst Dec 20, 2018
5bf06a1
Move vendored css ponyfill to npm
ChristophWurst Dec 20, 2018
1e80259
Remove core.js
ChristophWurst Dec 20, 2018
b3b4141
Move dev deps to devDependencies
ChristophWurst Dec 20, 2018
01a6181
Don't load old vendor files during jsunit tests
ChristophWurst Dec 21, 2018
69410a4
Adjust release file list
ChristophWurst Dec 21, 2018
15400fc
Use `jquery-ui-dist` instead of `jquery-ui` to resolve an issue with …
ChristophWurst Dec 21, 2018
a340273
Mergejs is gone
rullzer Dec 22, 2018
83068c3
Update select2, include css
ChristophWurst Dec 23, 2018
dbee410
Override select2 lib styling
skjnldsv Jan 7, 2019
e4e5cf8
Use upstream strengthify lib
ChristophWurst Jan 8, 2019
96102c1
Fix select2 style preference
juliusknorr Jan 9, 2019
1728075
Bump select2 from 3.4.5 to 3.4.8
ChristophWurst Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove core.js 
Signed-off-by: Christoph Wurst <[email protected]>
  • Loading branch information
@ChristophWurst @juliusknorr
ChristophWurst authored and juliusknorr committed Jan 9, 2019
commit 1e80259051cd1b6e4ded633f93d6b1ca06b78a52
39 changes: 0 additions & 39 deletions build/mergejs.php
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions build/mergejschecker.sh
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions core/js/core.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
{
"vendor": [
"css-vars-ponyfill/dist/css-vars-ponyfill.min.js"
],
"libraries": [
"jquery-showpassword.js",
"jquery.avatar.js",
Expand Down
10 changes: 0 additions & 10 deletions core/vendor/core.js
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions lib/private/legacy/template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,26 +124,6 @@ public static function initTemplateEngine($renderAs) {
OC_Util::addScript('files/client');
OC_Util::addScript('contactsmenu');
OC_Util::addScript('contactsmenu_templates');

if (\OC::$server->getConfig()->getSystemValue('debug')) {
// Add the stuff we need always
// following logic will import all vendor libraries that are
// specified in core/js/core.json
$fileContent = file_get_contents(OC::$SERVERROOT . '/core/js/core.json');
if($fileContent !== false) {
$coreDependencies = json_decode($fileContent, true);
foreach(array_reverse($coreDependencies['vendor']) as $vendorLibrary) {
//remove trailing ".js" as addVendorScript will append it
OC_Util::addVendorScript(
substr($vendorLibrary, 0, -3),null,true);
}
} else {
throw new \Exception('Cannot read core/js/core.json');
}
} else {
// Import all (combined) default vendor libraries
OC_Util::addVendorScript('core', null, true);
}
OC_Util::addScript('core', 'dist/main', true);

if (\OC::$server->getRequest()->isUserAgent([\OC\AppFramework\Http\Request::USER_AGENT_IE])) {
Expand Down