Rewrite getNumberOfUnreadCommentsForFolder query #13161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
blizzz,
danxuliu,
icewind1991 and
kesselb
ChristophWurst
approved these changes
Dec 20, 2018
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Change makes sense and code looks good!
👍 as discussed
Member
|
@rullzer can you cleanup your testing commits |
Member
Author
|
@icewind1991 once phan is happy I will ;) |
Before the joining and filtering removed unkown files. Resulting in manual queries for all the files with no (unread) comments (the 99%). Long story short. This will return a list of all the files in the parent folder with their unread comment count (can be 0). But this makes sure that the result is properly cached. In the dav handling. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
perf/fix_comments_in_folder_function
branch
from
1e6a9f3 to
f394bf3
Compare
Member
Author
|
Ok gave up. Just suppressed the warning |
Member
Author
|
@icewind1991 work your review magic |
Member
|
/backport to stable15 |
Member
|
According to EXPLAIN $query on mysql it eventually does not make a difference, identical output. |
blizzz
approved these changes
Jan 3, 2019
|
backport to stable15 in #13335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the joining and filtering removed unkown files. Resulting in
manual queries for all the files with no (unread) comments (the 99%).
Long story short. This will return a list of all the files in the parent
folder with their unread comment count (can be 0). But this makes sure
that the result is properly cached. In the dav handling.
Signed-off-by: Roeland Jago Douma [email protected]