Use a case insensitive search for email #13171
Merged
+36
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
icewind1991,
juliusknorr,
kesselb and
skjnldsv
|
|
||
| $result = $this->connection->executeQuery($sql, array($appName, $key, $value)); | ||
|
|
||
| $userIDs = array(); |
Member
There was a problem hiding this comment.
array_map to the rescue?
skjnldsv
approved these changes
Dec 20, 2018
ChristophWurst
added
4. to release
Member
|
@rullzer merge |
ChristophWurst
previously requested changes
Dec 20, 2018
Fixes #7084 Now entering wrongly cased email (roeland@ instead of Roeland@) for password reset etc. Will also work. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
fix/7084/case_insensitive_email_search
branch
from
fb05ef3 to
03fe2b3
Compare
ChristophWurst
approved these changes
Dec 20, 2018
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
|
backport to stable15 in #13179 |
|
backport to stable14 in #13180 |
Member
|
this will tank the query performance on large instances though |
Member
Author
|
Which is fine. It is a special case. We can optimize later but right now I do not see an other way |
Member
|
how about querying case sensitive first and only falling back to the slower query if there are no results |
Member
Author
|
Ah yes. Pr welcome ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7084
Now entering wrongly cased email (roeland@ instead of Roeland@) for
password reset etc. Will also work.
Propably good to backport at least to 15, even 14 maybe.