Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Dec 20, 2018

Else on scss files we'd get ?v=?v=
This is of course not valid. Now it becomes ?v=-

Before: <server>/css/comments/ca9f-d135-comments.css?v=db81cddf52fdb3c8ca1e4c859e214124?v=ca9f0d77-0
After: <server>/css/comments/ca9f-d135-comments.css?v=db81cddf52fdb3c8ca1e4c859e214124-ca9f0d77-0

Else on scss files we'd get <file>?v=<hash>?v=<hash2>
This is of course not valid. Now it becomes <file>?v=<hash>-<hash2>

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added bug 3. to review Waiting for reviews labels Dec 20, 2018
@rullzer rullzer added this to the Nextcloud 16 milestone Dec 20, 2018
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv
Copy link
Member

/backport to stable15

@backportbot-nextcloud
Copy link

backport to stable15 in #13209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants