do not forgot to store the second displayname portion #13187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise it causes a chain reaction of system addressbook updates Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
bug
3. to review
blizzz
requested review from
ChristophWurst,
juliusknorr,
rullzer and
skjnldsv
skjnldsv
approved these changes
Dec 21, 2018
ChristophWurst
approved these changes
Dec 21, 2018
Member
|
Failure unrelated |
skjnldsv
deleted the
fix/noid/ldap-misses-store-2n-displayname-portion
branch
Member
|
so … backport? |
Member
|
@ChristophWurst backport to stable15 |
Member
|
and 14 and 13? The commit that causes theses issues was backported as well. |
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
Member
Author
|
/backport to stable13 |
|
backport to stable15 in #13218 |
|
backport to stable14 in #13219 |
This was referenced Dec 21, 2018
|
backport to stable13 in #13220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given your LDAP configuration defined a "Second displayname" attribute (e.g.) that is show behind the main one in brackets, then user listings and logins will create a cascade of system addressbook updated, because in one code path we missed to consider the second attribute when storing the displayname in the database. This fixes it. A final update will happen to end up with the correct value.