Skip to content

Add caching headers for public previews #13326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jan 3, 2019
Merged

Add caching headers for public previews #13326

MorrisJobke merged 1 commit into from
Jan 3, 2019

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 2, 2019

This adds proper caching headers to public image previews.

Fixes #13290

@juliusknorr juliusknorr added this to the Nextcloud 16 milestone Jan 2, 2019
rullzer
rullzer approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yes. Good point.

@rullzer rullzer mentioned this pull request Jan 3, 2019
Closed
@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 3, 2019

Do we have a Cache buster here? The etag would be perfect,no?

@rullzer
Copy link
Member

rullzer commented Jan 3, 2019

Do we have a Cache buster here? The etag would be perfect,no?

Won't help if you embed the image of course.
In general if you refresh the etag will be checked.

MorrisJobke
MorrisJobke approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 3, 2019

/backport to stable15

@MorrisJobke MorrisJobke merged commit 211926c into master Jan 3, 2019
@MorrisJobke MorrisJobke deleted the bugfix/13290/cache-public-preview branch January 3, 2019 09:36
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 3, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 3, 2019

backport to stable15 in #13328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: previews and thumbnails feature: sharing

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @MorrisJobke @rullzer