Skip to content

Conversation

@MorrisJobke
Copy link
Member

Backport of #13363

@MorrisJobke MorrisJobke added bug 3. to review Waiting for reviews labels Jan 4, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 13.0.9 milestone Jan 4, 2019
@MorrisJobke MorrisJobke requested review from blizzz and rullzer January 4, 2019 21:56
@MorrisJobke MorrisJobke force-pushed the backport/13363/stable13 branch from 3cebf47 to c38d838 Compare January 4, 2019 22:03
@MorrisJobke
Copy link
Member Author

There was the method getServerPath added in 15.0.0 and back ported to stable14 in #12177 - I added it to this branch as well. After that the login works just fine. 👍

return new Http\RedirectResponse($redirectUri);
}

private function getServerPath(): string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 also support php5. 6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting

It seems iOS doesn't like us to change the location. So now we submit it
to the server that geneartes the redirect.

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer force-pushed the backport/13363/stable13 branch from c38d838 to 2757a42 Compare January 5, 2019 14:55
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

@rullzer rullzer merged commit de761e2 into stable13 Jan 5, 2019
@rullzer rullzer deleted the backport/13363/stable13 branch January 5, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants