explicitly close the streams when doing recursive copy #13410
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
CI failures :( |
MorrisJobke
added
2. developing
Member
@icewind1991 Any news on this one here? |
Member
|
Member
|
@icewind1991 What is the status here? We are close to the beta 1. Should this go into 17 or 18? |
Signed-off-by: Robin Appelman <[email protected]>
kesselb
force-pushed
the
copyr-close-streams
branch
from
961d16f to
d0dc07e
Compare
Member
|
@icewind1991 funny, because we just merged another PR of yours that removes explicit fclose in another context here #26072 |
Member
|
Let's close this. It's open since over 2 years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes some of the "Access to undeclared static property: OC\Files\Filesystem::$normalizedPathCache" errors but ran into some unrelated problems when trying to get a reproduce things properly.