deleted files, fix mimetype detection #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schiessle, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @PVince81 and @nickvergessen to be potential reviewers |
Member
Author
|
Nextcloud 10 is also affected, I will prepare a backport. |
…e have to check the filename without the appended timestamp
schiessle
force-pushed
the
trash-detect-correct-mimetype
branch
from
c6fbd56 to
68b5366
Compare
Member
|
Tested and works 👍 |
Member
|
cc @rullzer |
Member
|
LGTM |
Member
|
@schiessle @karlitschek I would like to see this backported to stable10 |
Member
|
please backport 👍 |
Member
Author
|
stable10: #1367 |
This was referenced Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detect the correct mimetype of the files in the trashbin, therefore we have to check the filename without the appended timestamp
bug was introduced here: 435cd31
We can't rely on the file cache, because the files in the trash bin are named
<filename>.<extension>.d<timestamp>to get the correct mimetype we need to check the real filename without the time stamp when we compile the list.cc @MorrisJobke @icewind1991
fix #1337