Show the repair steps and repair info output in the web for better feedback #13467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edback Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
requested review from
ChristophWurst,
blizzz,
kesselb,
nickvergessen and
rullzer
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
Member
Author
|
/backport to stable13 |
nickvergessen
approved these changes
Jan 10, 2019
|
backport to stable15 in #13469 |
|
backport to stable14 in #13470 |
|
backport to stable13 in #13471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this after a longer running repair step that the web UI showed the output of the previous one. Obviously the steps are only shown shortly, but the can give you an idea what is taking so long.
Should we add this to 15.0.1 because there we introduced the long repair step for the activity table? It's IMO a quite simple fix as well.
Before:
After:
