Skip to content

fix remember me login #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 6 commits into from
Nov 2, 2016
Merged

fix remember me login #1347

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d907666
bring back remember-me
ChristophWurst Sep 6, 2016
6f86e46
inject ISecureRandom into user session and use injected config too
ChristophWurst Oct 31, 2016
b269ed5
Fix invalid PHPDocs
LukasReschke Nov 2, 2016
271f2a4
Fix typ in constant name
LukasReschke Nov 2, 2016
9d6e01e
Add missing tests and fix PHPDoc
LukasReschke Nov 2, 2016
4da6b20
document what the method does
ChristophWurst Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
document what the method does 
Signed-off-by: Christoph Wurst <[email protected]>
  • Loading branch information
@ChristophWurst
ChristophWurst committed Nov 2, 2016
commit 4da6b20e768574e2ec6a7da590273e18b64ddda5
2 changes: 2 additions & 0 deletions lib/private/Authentication/Token/IProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public function generateToken($token, $uid, $loginName, $password, $name, $type
public function getToken($tokenId) ;

/**
* Duplicate an existing session token
*
* @param string $oldSessionId
Copy link
Member

@LukasReschke LukasReschke Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add at least a single line comment what the function is supposed to do? :)

Copy link
Member Author

@ChristophWurst ChristophWurst Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* @param string $sessionId
* @throws InvalidTokenException
Expand Down