Provide initial state for backupcodes in template #13481
Conversation
|
I also bumped the dependencies and added the compiled assets to the gitattributes |
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Just a nitpick
will test in a minute, just to see how fast it loads :)
| el: '#twofactor-backupcodes-settings', | ||
| render: h => h(PersonalSettings) | ||
| }); | ||
| const initialStateElem = JSON.parse(atob(document.getElementById('twofactor-backupcodes-initial-state').value)); |
There was a problem hiding this comment.
nitpick: the variable name is misleading. I guess you wanted to do the .value below when you pass it to the store
There was a problem hiding this comment.
Because it is base64 encoded. Else we might run into some random errors with quotes
There was a problem hiding this comment.
We use json_encode directly for settings :)
https://github.com/nextcloud/server/blob/master/settings/templates/settings-vue.php#L30
There was a problem hiding this comment.
still feels more error prone. base64 is guaranteed not to contain special chars that might break things
rullzer
force-pushed
the
omit_fetching_state
branch
from
09657ff to
53b7345
Compare
|
@skjnldsv can I also get a 👍 😉 |
rullzer
force-pushed
the
omit_fetching_state
branch
from
53b7345 to
972f9e3
Compare
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good and works nicely 👍
This saves a direct request to the server when loading the backup codes. There is no need for this as the data is already known. Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
omit_fetching_state
branch
from
972f9e3 to
90f8687
Compare
This saves a direct request to the server when loading the backup codes.
There is no need for this as the data is already known.
Signed-off-by: Roeland Jago Douma [email protected]