Remove unused 'Base64' polyfill #13491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
enhancement
3. to review
ChristophWurst
requested review from
MorrisJobke,
blizzz,
juliusknorr,
rullzer and
skjnldsv
ChristophWurst
force-pushed
the
refactor/remove-unused-base64-polyfill
branch
from
37b6690 to
f5a8742
Compare
juliusknorr
approved these changes
Jan 11, 2019
Member
|
conflicts ;) |
Ref #13460 (comment) Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
refactor/remove-unused-base64-polyfill
branch
from
f5a8742 to
4b5518f
Compare
ChristophWurst
added
4. to release
Member
Author
|
@rullzer merge |
Member
Author
|
Btw, if you've ever wondered why our current bundle is 1MB big, here's a little visualization: Time to get rid of jquery-ui and modularize the moment l10n code :D |
Member
An interesting discussion needs to happen: nextcloud-libraries/nextcloud-vue#146 (comment) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't required anymore as
atobandbtoais now supported in all major browsers according to caniuse.Ref #13460 (comment)
Replaces #13460