Fix grid toggle button on public page #13514
Conversation
skjnldsv
added
bug
design
skjnldsv
requested review from
MorrisJobke,
jancborchardt,
juliusknorr,
rullzer and
weeman1337
|
/backport to stable15 |
|
Thank you @jancborchardt for the heads up and @skjnldsv for finding the issue. |
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
We still need to keep the check, otherwise we have the button on single file shares as well:
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Also, the button should not have the button style (background and border), just like when logged in. :)
juliusknorr
added
2. developing
|
Since there are several issues with the grid button, maybe it makes sense to put some tests in for that! |
|
@weeman1337 sure! Wanna help? :D |
I knew that would come :) A ticket for me: #13613 |
|
Hi guys, so sharing link though the gallery app has toggle button, once I press it it goes to file list and the button disappears Also "Download" and "Download all files" :-) https://victorsea.photography/nextcloud/index.php/apps/gallery/s/6iRrgxTNTmdF5eJ# |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
fix-public-grid-toggle
branch
from
e3d4cb4 to
ee2c45d
Compare
skjnldsv
added
3. to review
|
This one slipped through! |
|
backport to stable15 in #14376 |
|
Old behavior of the toggle was to change the URL on the top, so that it was possible to permalink to gallery view and the link to point to gallery view on page load. Latest versions of NextCloud do not allow that anymore because the toggle does not change add any URL fragment to account for that. Is there a way to at least manipulate the URL manually to achieve the same result? Tried on v18.0.6. |
|
It would be great to be able to decide how we want to share a folder, list or thumb |
Broken by #12385
Fix #13375