Skip to content

Principals can be principal/user/<name> or principal/<name> from lega… #13573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jan 14, 2019
Merged

Principals can be principal/user/<name> or principal/<name> from lega… #13573

MorrisJobke merged 1 commit into from
Jan 14, 2019

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 14, 2019

…cy installs

At least there is a conversion method:

server/apps/dav/lib/Connector/LegacyDAVACL.php

Lines 53 to 59 in d3d045d

private function convertPrincipal($principal, $toV2) {
list(, $name) = \Sabre\Uri\split($principal);
if ($toV2) {
return "principals/users/$name";
}
return "principals/$name";
}

And a matching report by @cunningwasabi in #13499 (comment)

@nickvergessen nickvergessen added this to the Nextcloud 16 milestone Jan 14, 2019
rullzer
rullzer approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 14, 2019

/backport to stable15

@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 14, 2019

/backport to stable14

@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 14, 2019

/backport to stable13

skjnldsv
skjnldsv approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 14, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Jan 14, 2019

Failure seems unrelated

@MorrisJobke MorrisJobke merged commit c6cf871 into master Jan 14, 2019
@MorrisJobke MorrisJobke deleted the bugfix/noid/one-last-time branch January 14, 2019 13:18
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 14, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 14, 2019

backport to stable15 in #13582

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 14, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 14, 2019

backport to stable14 in #13583

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 14, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 14, 2019

backport to stable13 in #13584

BernieO referenced this pull request in BernieO/calcardbackup Feb 13, 2019
@BernieO
take into account that principals can be principals/<username> from l…
1c8fe29 
…egacy installs
BernieO referenced this pull request in BernieO/calcardbackup Feb 14, 2019
@BernieO
take into account that principals can be principals/<username> from l…
da7b815 
…egacy installs

 Backport of commit 1c8fe29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: dav

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @skjnldsv @rullzer @blizzz @MorrisJobke