Allow apps to register an initial state #13646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
skjnldsv
skjnldsv
changed the title
MorrisJobke
reviewed
Jan 18, 2019
Member
Author
|
This is on hold until @ChristophWurst is done fiddling with the webpack stuff. So we don't end up endlessly rebasing |
ChristophWurst
requested changes
Jan 25, 2019
1 task
Member
Author
|
@MorrisJobke @ChristophWurst comments address. Will rebase and squash with the green light ;) |
rullzer
added
3. to review
MorrisJobke
reviewed
Jan 29, 2019
MorrisJobke
approved these changes
Jan 29, 2019
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Beside my comment this looks good 👍
rullzer
force-pushed
the
enh/13488/initialstate
branch
4 times, most recently
from
cead3c0 to
b5ca7d9
Compare
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
enh/13488/initialstate
branch
from
b5ca7d9 to
f30877e
Compare
2 tasks
skjnldsv
reviewed
Jan 30, 2019
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
You'll add tests later? (looking at the OP) 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13488
This introduces a way for apps to register their initial state so this does not have to be fetched async.
Todo: