-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Allow caching of the logout route #13757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I really don't like that this is handled in there. I would handle it directly in the logout URL handling - just request the URL without any parameter and manually add it then. This reduces unnecessary complexity in the reused method |
|
Then somebody with JS magic skills needs to tackle it |
Why? It's PHP as well - I would just do it in here: server/lib/private/legacy/user.php Lines 266 to 280 in bb86a8c
😉 |
|
Aaaaah right ok makes sense. Let me do that then... |
10a5d38 to
84fefb3
Compare
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🐘 🙈
|
Still failing: |
By requesting the plain logout url we allow it to be properly cached by the caching router. We just add the requesttoken manually. Signed-off-by: Roeland Jago Douma <[email protected]>
3e9d93c to
ebd9f30
Compare
|
The acceptance test failures seem legit; for me, logging out now (sometimes) results in an error page with |
|
😢 |
Aaaah sometimes yes... OK I know what is going on... fix incomming |
Followup of #13757 Signed-off-by: Roeland Jago Douma <[email protected]>
It is a bit more general. If the only argument is the requesttoken. So a
get request will work with the CSRF protection. The route will be
generated without the parameters and the request token will be added at
the end.
Before the route could not properly be cached as the request token was
always changing. However now it can be cached saving precious cpu
cycles.
Noticed while looking at #13712. While #13712 is a general improvement for route generation this fixes the non caching of this specific route.