Skip to content

Fix S3 handling #13829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rullzer wants to merge 1 commit into from
Closed

Fix S3 handling #13829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dav/lib/Connector/Sabre/File.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public function put($data) {
$this->changeLock(ILockingProvider::LOCK_EXCLUSIVE);
}

if ($partStorage->instanceOfStorage(Storage\IWriteStreamStorage::class)) {
if (false && $partStorage->instanceOfStorage(Storage\IWriteStreamStorage::class)) {
Copy link
Member

@nickvergessen nickvergessen Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't instead S3 not implement IWriteStreamStorage anymore?
Other storages might support it?

Copy link
Member Author

@rullzer rullzer Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also possible yes. I just did the quick fix that made sure that other backends with possible bugs also are not affected. But yes maybe that is cleaner.
Let me fix that.

Copy link
Member Author

@rullzer rullzer Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah not so easy. As the S3 implementation extends Common. So I propose just to get this in and do more extensive fixes later.

$count = $partStorage->writeStream($internalPartPath, $data);
$result = $count > 0;
if ($result === false) {
Expand Down