-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Throttle getstoragestats.php calls and allow simultaneous uploads #13855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throttle getstoragestats.php calls and allow simultaneous uploads #13855
Conversation
Signed-off-by: Tomasz Grobelny <[email protected]>
MorrisJobke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works nicely 👍 Also the getStorageStats call on every upload is not there anymore. Nice finding 💯
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
|
Cool 👍
|
|
@danielkesselberg but but but what if I upload 100 tiny files? Then 10 concurrent will probably be faster 😉 |
This heavily depends on your uplink, server speed and filesize. I believe one could justify just about any value. I did my tests on a pcengines apu2c4 with about 5MB files and I was still far from reaching the link speed (got 10Mbit/s). |
|
Ok if this is a reasonable standard that works for most of your users. |
|
Why not make this an admin setting that we can set in the webGUI as an admin to tune it for our setup? I mean, hiding the setting seems like asking for trouble. Yes? :) |
Improves speed on #13854 and #13696. Does not address reliability in any way.