Skip to content

SCSS: add background on app section:hover #13877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 2 commits into from
Feb 4, 2019
Merged

SCSS: add background on app section:hover #13877

rullzer merged 2 commits into from
Feb 4, 2019

Conversation

@IGLOU-EU
Copy link
Contributor

@IGLOU-EU IGLOU-EU commented Jan 28, 2019

Very little SCSS PR.
Avoid miss click on app, focus attention.

@IGLOU-EU
add background on app hover section
240789f 
Avoid click on bad app, focus attention
@rullzer
Copy link
Member

rullzer commented Jan 30, 2019

@nextcloud/designers

@rullzer rullzer added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jan 30, 2019
@rullzer rullzer added this to the Nextcloud 16 milestone Jan 30, 2019
@rullzer
Copy link
Member

rullzer commented Jan 30, 2019

Welcome @IGLOU-EU! And thanks for your first PR.

@skjnldsv
Copy link
Member

skjnldsv commented Jan 30, 2019

@IGLOU-EU Welcome!
Could you attach screenshots to your PR? If this is a design change, we usually have our designers reviewing faster if there is a screenshot attached 😉

@IGLOU-EU
inadvertent error prevention on .row
4389b80 
Add a 5px border on .row settings section
@IGLOU-EU
Copy link
Contributor Author

IGLOU-EU commented Feb 2, 2019

Hi all,
sorry for the screen screenshot,
I add a gif for this PR.
PS: PR only for :hover stuff

peek 2019-02-02 11-50

rullzer
rullzer approved these changes Feb 2, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

skjnldsv
skjnldsv approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 4, 2019
@rullzer
Copy link
Member

rullzer commented Feb 4, 2019

@IGLOU-EU next time we'd need you to sign of your commits. But lets get this in now 😄

@rullzer rullzer merged commit a242ec6 into nextcloud:master Feb 4, 2019
@welcome
Copy link

welcome bot commented Feb 4, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

3 participants

@IGLOU-EU @rullzer @skjnldsv