Skip to content

Remove warning in case of external storage error #13891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jan 30, 2019
Merged

Remove warning in case of external storage error #13891

MorrisJobke merged 1 commit into from
Jan 30, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 29, 2019

No description provided.

@skjnldsv
Remove warning in case of external storage error
812567a 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews labels Jan 29, 2019
@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Jan 29, 2019
@skjnldsv skjnldsv self-assigned this Jan 29, 2019
ChristophWurst
ChristophWurst approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 30, 2019
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 30, 2019

/backport to stable15

@MorrisJobke MorrisJobke merged commit fda74eb into master Jan 30, 2019
@MorrisJobke MorrisJobke deleted the remove-external-failure-notification branch January 30, 2019 10:54
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 30, 2019
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jan 30, 2019

backport to stable15 in #13920

This was referenced Feb 7, 2019
Closed
Merged
@MorrisJobke
Copy link
Member

MorrisJobke commented Feb 7, 2019

There was a regression from this: #14022

Fix is in #14076

@blizzz
Copy link
Member

blizzz commented Feb 7, 2019

what was the reason for the removal?

@MorrisJobke
Copy link
Member

MorrisJobke commented Feb 7, 2019

what was the reason for the removal?

There was a banner at the top that was not dismissible and caused a lot of confusion, because already the entry shows the "this mount is not available" information. Thus we decided to remove the notification banner.

@blizzz
Copy link
Member

blizzz commented Feb 7, 2019

makes sense, ideally in future this is part of the PR text or better the commit message. In a couple months nobody knows anymore :)

@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

6 participants

@skjnldsv @MorrisJobke @blizzz @ChristophWurst @juliusknorr