Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jan 30, 2019

Once done this will make it obsolete to load 95% or the scripts we currently load on the login page, meaning that users will see faster page loads when the open the login page on a (new) device with empty caches.

@MorrisJobke
Copy link
Member

Once done this will make it obsolete to load 95% or the scripts we currently load on the login page, meaning that users will see faster page loads when the open the login page on a (new) device with empty caches.

Or after an update 😉

@rullzer
Copy link
Member

rullzer commented Jan 31, 2019

🚀

Of course a good second step would be to add something that does preloading of required files for after the login. Once the login page is done loading.

But first this yes!

@rullzer rullzer modified the milestones: Nextcloud 16, Nextcloud 17 Feb 25, 2019
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels Mar 6, 2019
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Apr 30, 2019
@ChristophWurst ChristophWurst force-pushed the refactor/login-bundle branch from 220d95c to 9adfb7e Compare April 30, 2019 06:55
@ChristophWurst
Copy link
Member Author

ChristophWurst commented May 2, 2019

Almost there 😁

  • BUG: clicking the lost password element triggers an error, OC.getRootPath is still added via js.js
    Bildschirmfoto von 2019-05-02 15-49-13

@ChristophWurst ChristophWurst force-pushed the refactor/login-bundle branch from 1b07e66 to 73ee44e Compare May 7, 2019 06:46
@ChristophWurst
Copy link
Member Author

Tested and works 🚀 💃 🎊

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 7, 2019
@ChristophWurst ChristophWurst force-pushed the refactor/login-bundle branch from 73ee44e to 0f5f125 Compare May 7, 2019 06:50
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!! Yeeeeesss!! 🚀 🚀 🙏

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but for me the main.js with 1,2 MB is still loaded. Is this correct?

@MorrisJobke
Copy link
Member

Also before it was 32 requests with 1,7 MB in total and after it is 29 requests with 2,1 MB. 🤔

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 7, 2019
@ChristophWurst
Copy link
Member Author

Works, but for me the main.js with 1,2 MB is still loaded. Is this correct?

I actually haven't checked recently. But it could very well be the case as it's just loaded everywhere.

@ChristophWurst
Copy link
Member Author

It's loaded for every template

OC_Util::addScript('core', 'dist/main', true);
. This has to be adjusted slightly to only load a predefined set of scripts for the different types of templates we have.

@MorrisJobke MorrisJobke force-pushed the refactor/login-bundle branch from 0f5f125 to 3cc8c9b Compare May 7, 2019 12:28
@MorrisJobke
Copy link
Member

I fixed the conflicts here.

@MorrisJobke
Copy link
Member

Looks good except the git clone problems. Merging now.

@MorrisJobke MorrisJobke merged commit ee6011d into master May 7, 2019
@MorrisJobke MorrisJobke deleted the refactor/login-bundle branch May 7, 2019 13:11
@icewind1991
Copy link
Member

This change breaks password reset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants